Issue 235933007: DevTools: [CodeMirror] collapse single selection on esc key

Issue 235933007: DevTools: [CodeMirror] collapse single selection on esc key (Closed)

Created:
6 years, 8 months ago by lushnikov

Modified:
6 years, 8 months ago

Reviewers:
apavlov, vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [CodeMirror] collapse single selection on esc key Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171473

Patch Set 1 #

Patch Set 2 : simplify code #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -38 lines)			Patch
	M	Source/devtools/front_end/CodeMirrorTextEditor.js	View	1	16 chunks	+28 lines, -38 lines	1 comment	Download
	M	Source/devtools/front_end/CodeMirrorUtils.js	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/235933007/diff/20001/Source/devtools/front_end/CodeMirrorTextEditor.js File Source/devtools/front_end/CodeMirrorTextEditor.js (right): https://codereview.chromium.org/235933007/diff/20001/Source/devtools/front_end/CodeMirrorTextEditor.js#newcode267 Source/devtools/front_end/CodeMirrorTextEditor.js:267: CodeMirror.commands.dismissMultipleSelections = function(codemirror) Annotate?

6 years, 8 months ago (2014-04-14 13:00:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/235933007/20001

6 years, 8 months ago (2014-04-14 13:02:30 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-14 13:45:40 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on win_blink_rel

6 years, 8 months ago (2014-04-14 13:45:41 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/235933007/20001

6 years, 8 months ago (2014-04-14 14:57:58 UTC) #8

Message was sent while issue was closed.

Change committed as 171473

Expand Messages | Collapse Messages