Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 235933004: 3rd part of porting Chrome Ash to Windows 7 (Closed)

Created:
6 years, 8 months ago by ananta
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

3rd part of porting Chrome Ash to Windows 7 This is the Chrome side that 1- removes windows 8 specific checks 2- disconnects the fake window_tree_host_win 3- connects the remote_window_tree_host_win With this change you can now see the ash desktop but not interact with it since input events have not been enabled. Here is the second part https://codereview.chromium.org/211863003/ First part with rationale: https://codereview.chromium.org/199843004/ Note: this is a redo & rebase of https://codereview.chromium.org/227573007/ BUG=356475 TEST=none patch from issue 235683005 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264680

Patch Set 1 #

Patch Set 2 : ash_unittests fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -44 lines) Patch
M ash/host/ash_window_tree_host_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_platform_part_aurawin.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M chrome/browser/metro_utils/metro_chrome_win.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/gfx/win/dpi.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 chunk +11 lines, -9 lines 0 comments Download
M win8/metro_driver/metro_driver_win7.cc View 8 chunks +23 lines, -7 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 2 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
Meta question. If we want to run this on the desktop, why bother using the ...
6 years, 8 months ago (2014-04-14 20:30:06 UTC) #1
ananta
On 2014/04/14 20:30:06, sky wrote: > Meta question. If we want to run this on ...
6 years, 8 months ago (2014-04-17 20:48:14 UTC) #2
sky
I still have concerns about this approach and was hoping to talk with cpu when ...
6 years, 8 months ago (2014-04-17 22:02:59 UTC) #3
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 8 months ago (2014-04-17 23:15:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/235933004/20001
6 years, 8 months ago (2014-04-17 23:17:23 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 00:05:01 UTC) #6
Message was sent while issue was closed.
Change committed as 264680

Powered by Google App Engine
This is Rietveld 408576698