runtime/vm/assembler_x64.cc - Issue 2359313002: Disassembler: use the register names we generally use with our assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_x64.cc

Issue 2359313002: Disassembler: use the register names we generally use with our assembler. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/assembler_x64.cc

diff --git a/runtime/vm/assembler_x64.cc b/runtime/vm/assembler_x64.cc

index 48e2613ede234e7db956b4c79f41d337ea9d760d..213b8cb2cd5bdb6480de789e4bd367452b916df4 100644

--- a/runtime/vm/assembler_x64.cc

+++ b/runtime/vm/assembler_x64.cc

@@ -3767,7 +3767,7 @@ Address Assembler::ElementAddressForRegIndex(bool is_external,

static const char* cpu_reg_names[kNumberOfCpuRegisters] = {

"rax", "rcx", "rdx", "rbx", "rsp", "rbp", "rsi", "rdi",

- "r8", "r9", "r10", "r11", "r12", "r13", "r14", "r15"

+ "r8", "r9", "r10", "r11", "r12", "r13", "thr", "pp"

};

« no previous file with comments | « no previous file | runtime/vm/disassembler_arm.cc » ('j') | no next file with comments »