Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2359263002: Fix a gpu pixel test for WebGL's commit() API (Closed)

Created:
4 years, 3 months ago by xidachen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, kinuko+watch, darin-cc_chromium.org, blink-worker-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a gpu pixel test for WebGL's commit() API When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increment the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/feeffa93ab854317d5435f6c9a2a17d1e49b6857 Cr-Commit-Position: refs/heads/master@{#420683}

Patch Set 1 #

Total comments: 2

Patch Set 2 : main thread wait for worker to send back msg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html View 1 3 chunks +4 lines, -1 line 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (18 generated)
xidachen
PTAL
4 years, 3 months ago (2016-09-22 18:40:17 UTC) #3
Justin Novosad
On 2016/09/22 18:40:17, xidachen wrote: > PTAL Could you change the headline so that it ...
4 years, 3 months ago (2016-09-22 21:08:23 UTC) #5
Ken Russell (switch to Gerrit)
Filed http://crbug.com/649485 about the webgl2_conformance_tests failure. https://codereview.chromium.org/2359263002/diff/1/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html File content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html (right): https://codereview.chromium.org/2359263002/diff/1/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html#newcode24 content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html:24: self.postMessage(""); I think ...
4 years, 3 months ago (2016-09-22 21:11:44 UTC) #6
Ken Russell (switch to Gerrit)
LGTM with the caveats mentioned above, since I just lgtm'd Olivia's similar CL with the ...
4 years, 3 months ago (2016-09-22 22:48:11 UTC) #7
xidachen
On 2016/09/22 22:48:11, Ken Russell wrote: > LGTM with the caveats mentioned above, since I ...
4 years, 3 months ago (2016-09-23 00:07:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359263002/20001
4 years, 3 months ago (2016-09-23 18:50:15 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 18:59:48 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:02:33 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/feeffa93ab854317d5435f6c9a2a17d1e49b6857
Cr-Commit-Position: refs/heads/master@{#420683}

Powered by Google App Engine
This is Rietveld 408576698