|
|
DescriptionFix a gpu pixel test for WebGL's commit() API
When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added,
the generated reference image is a blank image which is incorrect. Now
we have fixed the problem, the reference image needs to be updated. So
this CL increment the revision number for the test by 1. This CL also
updates the test by post an empty message back from worker-->main thread.
BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/feeffa93ab854317d5435f6c9a2a17d1e49b6857
Cr-Commit-Position: refs/heads/master@{#420683}
Patch Set 1 #
Total comments: 2
Patch Set 2 : main thread wait for worker to send back msg #
Messages
Total messages: 26 (18 generated)
Description was changed from ========== Increament revision number for commit() pixel test When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increament the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. ========== to ========== Increament revision number for commit() pixel test When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increament the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
xidachen@chromium.org changed reviewers: + junov@chromium.org, kbr@chromium.org
PTAL
Description was changed from ========== Increament revision number for commit() pixel test When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increament the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Increament revision number for commit() pixel test When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increament the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
On 2016/09/22 18:40:17, xidachen wrote: > PTAL Could you change the headline so that it describes what this CL fixes. Otherwise, non-owner lgtm
Filed http://crbug.com/649485 about the webgl2_conformance_tests failure. https://codereview.chromium.org/2359263002/diff/1/content/test/data/gpu/pixel... File content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html (right): https://codereview.chromium.org/2359263002/diff/1/content/test/data/gpu/pixel... content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html:24: self.postMessage(""); I think you need to wait for this to be received by the main thread before starting the countdown to notifying the caller that the test is done. https://codereview.chromium.org/2359263002/diff/1/content/test/gpu/page_sets/... File content/test/gpu/page_sets/pixel_tests.py (right): https://codereview.chromium.org/2359263002/diff/1/content/test/gpu/page_sets/... content/test/gpu/page_sets/pixel_tests.py:190: revision=2, I assume the reason this passes the CQ is that the test's already marked failing.
LGTM with the caveats mentioned above, since I just lgtm'd Olivia's similar CL with the same caveat.
Description was changed from ========== Increament revision number for commit() pixel test When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increament the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Increment revision number for commit() pixel test When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increament the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Increment revision number for commit() pixel test When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increament the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Increment revision number for commit() pixel test When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increment the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
On 2016/09/22 22:48:11, Ken Russell wrote: > LGTM with the caveats mentioned above, since I just lgtm'd Olivia's similar CL > with the same caveat. That makes sense Ken. Before landing this patch, I would like to verify that it is at least consistently passing locally.
Description was changed from ========== Increment revision number for commit() pixel test When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increment the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Fix a gpu pixel test for WebGL's commit() API When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increment the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by xidachen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by xidachen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xidachen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, junov@chromium.org Link to the patchset: https://codereview.chromium.org/2359263002/#ps20001 (title: "main thread wait for worker to send back msg")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix a gpu pixel test for WebGL's commit() API When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increment the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Fix a gpu pixel test for WebGL's commit() API When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increment the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix a gpu pixel test for WebGL's commit() API When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increment the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Fix a gpu pixel test for WebGL's commit() API When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increment the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/feeffa93ab854317d5435f6c9a2a17d1e49b6857 Cr-Commit-Position: refs/heads/master@{#420683} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/feeffa93ab854317d5435f6c9a2a17d1e49b6857 Cr-Commit-Position: refs/heads/master@{#420683} |