Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2359243004: Minor improvements of task list (Closed)

Created:
4 years, 2 months ago by kjlubick
Modified:
4 years, 2 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
git@github.com:luci/luci-py@task-list
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Minor improvements of task list Adds "bot assigned" column. Fixes the filter boxes when wide input is in there. Makes user:none work appropriately with backend server. BUG=631047 Committed: https://github.com/luci/luci-py/commit/58223a4e436532c3c30ca0ad7e9893bb4d8749c9

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -24 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 2 3 chunks +11 lines, -9 lines 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list.html View 1 chunk +9 lines, -7 lines 0 comments Download
M appengine/swarming/elements/res/imp/common/query-column-filter-behavior.html View 1 chunk +0 lines, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-filters.html View 1 chunk +5 lines, -0 lines 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-list.html View 1 2 4 chunks +20 lines, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-list-data.html View 1 2 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kjlubick
4 years, 2 months ago (2016-09-23 14:05:29 UTC) #3
stephana
On 2016/09/23 14:05:29, kjlubick wrote: LGTM
4 years, 2 months ago (2016-09-26 19:53:13 UTC) #4
KevinL
lgtm
4 years, 2 months ago (2016-09-26 19:55:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359243004/1
4 years, 2 months ago (2016-09-26 19:55:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3180e409f82ed710)
4 years, 2 months ago (2016-09-26 19:58:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359243004/40001
4 years, 2 months ago (2016-09-26 20:10:43 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 20:14:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/58223a4e436532c3c30ca0ad7e9893bb4d8749c9

Powered by Google App Engine
This is Rietveld 408576698