Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2359233002: Add support for getting the sessionId from instrumentation and sending it to the client (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for getting the sessionId from instrumentation and sending it to the client R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/74686371b3dc98814a6276956f2c402ae9a3ee3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -14 lines) Patch
M pkg/analysis_server/doc/api.html View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 7 chunks +28 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_files View 1 chunk +13 lines, -9 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/instrumentation/file_instrumentation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 3 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/instrumentation/instrumentation_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-22 17:15:21 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-22 17:18:05 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-22 17:26:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74686371b3dc98814a6276956f2c402ae9a3ee3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698