Issue 235923013: Handlify TypedArray setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235923013: Handlify TypedArray setters. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify TypedArray setters. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20749

Patch Set 2 : fixed comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -160 lines)			Patch
	M	src/objects.h	View	1	9 chunks	+18 lines, -36 lines	0 comments	Download
	M	src/objects.cc	View		7 chunks	+52 lines, -124 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

lgtm https://codereview.chromium.org/235923013/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/235923013/diff/1/src/objects.h#newcode4921 src/objects.h:4921: // and undefined. Nit: keep the "clamping" comment

6 years, 8 months ago (2014-04-15 08:04:34 UTC) #2

Yang

https://codereview.chromium.org/235923013/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/235923013/diff/1/src/objects.h#newcode4921 src/objects.h:4921: // and undefined. On 2014/04/15 08:04:34, Dmitry Lomov (chromium) ...

6 years, 8 months ago (2014-04-15 08:09:26 UTC) #3

Yang

6 years, 8 months ago (2014-04-15 08:15:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20749 (presubmit successful).

Expand Messages | Collapse Messages

Issue 235923013: Handlify TypedArray setters. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixed comment #

Messages