Issue 235923003: <webview>: Move download permission to chrome

Issue 235923003: <webview>: Move download permission to chrome (Closed)

Created:
6 years, 8 months ago by Fady Samuel

Modified:
6 years, 8 months ago

Reviewers:
Alexei Svitkine (slow), jam, lazyboy

CC:
chromium-reviews, darin-cc_chromium.org, jam, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@move_media_to_chrome

Visibility:
Public.

More Reviews

Description

<webview>: Move download permission to chrome BUG=330264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264117

Patch Set 4 : Updated actions.xml #

Patch Set 5 : Addressed nits #

Patch Set 6 : Removed extra whitespace #

Patch Set 7 : Merge with ToT #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -49 lines)			Patch
M	chrome/browser/guestview/webview/webview_guest.h	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/guestview/webview/webview_guest.cc	View	1 2 3 4	8 chunks	+35 lines, -10 lines	0 comments	Download
M	chrome/browser/guestview/webview/webview_permission_types.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_guest.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_guest.cc	View	1 2	4 chunks	+13 lines, -36 lines	0 comments	Download
M	content/public/browser/browser_plugin_guest_delegate.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/public/browser/browser_plugin_guest_delegate.cc	View	1 2 3 4 5	1 chunk	+7 lines, -0 lines	0 comments	Download
M	content/public/common/browser_plugin_permission_type.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/metrics/actions/actions.xml	View	1 2 3	4 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

lazyboy

lgtm https://chromiumcodereview.appspot.com/235923003/diff/20001/chrome/browser/guestview/webview/webview_guest.cc File chrome/browser/guestview/webview/webview_guest.cc (right): https://chromiumcodereview.appspot.com/235923003/diff/20001/chrome/browser/guestview/webview/webview_guest.cc#newcode930 chrome/browser/guestview/webview/webview_guest.cc:930: remove empty lines https://chromiumcodereview.appspot.com/235923003/diff/20001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://chromiumcodereview.appspot.com/235923003/diff/20001/tools/metrics/actions/actions.xml#newcode10712 ...

6 years, 8 months ago (2014-04-11 23:25:05 UTC) #3

Fady Samuel

+jam@ for content/public +asvitkine@ for actions.xml https://codereview.chromium.org/235923003/diff/20001/chrome/browser/guestview/webview/webview_guest.cc File chrome/browser/guestview/webview/webview_guest.cc (right): https://codereview.chromium.org/235923003/diff/20001/chrome/browser/guestview/webview/webview_guest.cc#newcode930 chrome/browser/guestview/webview/webview_guest.cc:930: On 2014/04/11 23:25:05, ...

6 years, 8 months ago (2014-04-14 22:59:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/235923003/110001

6 years, 8 months ago (2014-04-16 00:02:36 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/235923003/110001

6 years, 8 months ago (2014-04-16 01:34:33 UTC) #9

Message was sent while issue was closed.

Change committed as 264117

Expand Messages | Collapse Messages