Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2359213002: Check in runtime/observatory/.packages (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check in runtime/observatory/.packages We won't remove it from the .gitignore file until we remove the build steps that overwrite it. BUG=https://github.com/dart-lang/sdk/issues/27412 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8dc3811050b6085353f8446b283ba20d2fd17aab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A runtime/observatory/.packages View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bill Hesse
4 years, 3 months ago (2016-09-22 16:19:43 UTC) #1
Bill Hesse
4 years, 3 months ago (2016-09-22 16:25:37 UTC) #3
Bill Hesse
TBR=cutch
4 years, 3 months ago (2016-09-22 16:36:57 UTC) #4
Bill Hesse
Committed patchset #1 (id:1) manually as 8dc3811050b6085353f8446b283ba20d2fd17aab (presubmit successful).
4 years, 3 months ago (2016-09-22 16:38:26 UTC) #6
Cutch
4 years, 3 months ago (2016-09-22 19:24:30 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698