win8/metro_driver/chrome_app_view_ash.h - Issue 23592024: Make the metro viewer responsible for relaunching browser in desktop mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win8/metro_driver/chrome_app_view_ash.h

Issue 23592024: Make the metro viewer responsible for relaunching browser in desktop mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile out LaunchDesktopInstanceHelper on non-AURA and fix style issues. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win8/metro_driver/chrome_app_view_ash.h

diff --git a/win8/metro_driver/chrome_app_view_ash.h b/win8/metro_driver/chrome_app_view_ash.h

index 57f20b95c41b40dc91934a43a103829aa01dc5ec..96b348cf378e0d49ceaad9171d35d1c6760e5634 100644

--- a/win8/metro_driver/chrome_app_view_ash.h

+++ b/win8/metro_driver/chrome_app_view_ash.h

@@ -10,13 +10,16 @@

#include <windows.ui.input.h>

#include <windows.ui.viewmanagement.h>

-#include "base/files/file_path.h"

#include "base/memory/scoped_ptr.h"

#include "base/message_loop/message_loop.h"

#include "base/strings/string16.h"

#include "ui/base/events/event_constants.h"

#include "win8/metro_driver/direct3d_helper.h"

+namespace base {

+ class FilePath;

Bernhard Bauer 2013/08/31 10:15:05 Nit: No indent (also below).

namespace IPC {

class Listener;

class ChannelProxy;

@@ -46,6 +49,7 @@ class ChromeAppViewAsh

// Returns S_OK on success.

static HRESULT Unsnap();

+ void OnOpenURLOnDesktop(const base::FilePath& shortcut, const string16& url);

void OnSetCursor(HCURSOR cursor);

void OnDisplayFileOpenDialog(const string16& title,

const string16& filter,

« no previous file with comments | « ui/metro_viewer/metro_viewer_messages.h ('k') | win8/metro_driver/chrome_app_view_ash.cc » ('j') | win8/metro_driver/chrome_app_view_ash.cc » ('J')