Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: chrome/browser/policy/cloud/cloud_policy_core.h

Issue 23592017: Fix policy invalidator lifecycle bugs for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud/cloud_policy_core.h
diff --git a/chrome/browser/policy/cloud/cloud_policy_core.h b/chrome/browser/policy/cloud/cloud_policy_core.h
index 96135dc23036a7299680895e9a99466862b5733d..199f36b017b750b5829a09c3bd1d243fe7f3a7c3 100644
--- a/chrome/browser/policy/cloud/cloud_policy_core.h
+++ b/chrome/browser/policy/cloud/cloud_policy_core.h
@@ -9,6 +9,7 @@
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
+#include "base/observer_list.h"
#include "base/prefs/pref_member.h"
#include "chrome/browser/policy/cloud/cloud_policy_constants.h"
@@ -29,6 +30,21 @@ class CloudPolicyStore;
// CloudPolicyRefreshScheduler which triggers periodic refreshes.
class CloudPolicyCore {
public:
+ // Callbacks for policy core events.
+ class Observer {
+ public:
+ virtual ~Observer();
+
+ // Called after the core is connected.
+ virtual void OnCoreConnected(CloudPolicyCore* core) = 0;
+
+ // Called after the refresh scheduler is started.
+ virtual void OnRefreshSchedulerStarted(CloudPolicyCore* core) = 0;
+
+ // Called before the core is disconnected.
+ virtual void OnCoreDisconnected(CloudPolicyCore* core) = 0;
+ };
+
CloudPolicyCore(const PolicyNamespaceKey& policy_ns_key,
CloudPolicyStore* store);
~CloudPolicyCore();
@@ -67,6 +83,12 @@ class CloudPolicyCore {
void TrackRefreshDelayPref(PrefService* pref_service,
const std::string& refresh_pref_name);
+ // Registers an observer to be notified of policy core events.
+ void AddObserver(Observer* observer);
+
+ // Removes the specified observer.
+ void RemoveObserver(Observer* observer);
+
private:
// Updates the refresh scheduler on refresh delay changes.
void UpdateRefreshDelayFromPref();
@@ -77,6 +99,7 @@ class CloudPolicyCore {
scoped_ptr<CloudPolicyService> service_;
scoped_ptr<CloudPolicyRefreshScheduler> refresh_scheduler_;
scoped_ptr<IntegerPrefMember> refresh_delay_;
+ ObserverList<Observer, true> observers_;
DISALLOW_COPY_AND_ASSIGN(CloudPolicyCore);
};

Powered by Google App Engine
This is Rietveld 408576698