Use constrained values for shouldDisableDesktopWorkarounds.

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 4097 matching lines @@
     }
 
     const WebMouseEvent& mouseEvent = static_cast<const WebMouseEvent&>(event);
 
     if (page())
         page()->pointerLockController().dispatchLockedMouseEvent(
             PlatformMouseEventBuilder(mainFrameImpl()->frameView(), mouseEvent),
             eventType);
 }
 
 bool WebViewImpl::shouldDisableDesktopWorkarounds()

[kenneth.r.christiansen, 2013/08/29 13:35:55]

If these are quirks, should we suffix the methods with Quirk?

But I guess the desktop workaround is the actual quirk.

Why not make aapplyDesktopWorkaroundQuirk() or similar.

[rune, 2013/08/29 13:57:53]

You mean negate it and call it shouldApplyDesktopWorkaroundQuirks instead?

Sounds like a good thing since the result is currently negated the only place
it's invoked from. It's not a quirk in the standards sense and workaround-quirk
sounds excessive to me. I'll see what others think about the name.

[aelias_OOO_until_Jul13, 2013/08/29 18:29:35]

It's used to decide whether to trigger Chromium's tap disambiguation (and we
kept the name general in case there would be something else like that in the
future).  I don't think we should use "quirk" since it's nothing to do with
standards quirk.  Maybe "workaround" is a bit confusing too, but I can't come up
with a better name.

 {
-    ViewportArguments arguments = mainFrameImpl()->frame()->document()->viewportArguments();
-    return arguments.width == ViewportArguments::ValueDeviceWidth || !arguments.userZoom
-        || (arguments.minZoom == arguments.maxZoom && arguments.minZoom != ViewportArguments::ValueAuto);
+    if (!settings()->viewportEnabled() || !isFixedLayoutModeEnabled())
+        return false;
+
+    // A document is considered adapted to small screen UAs if one of these holds:
+    // 1. The author specified viewport has a constrained width that is equal to
+    //    the initial viewport width.
+    // 2. The author has disabled viewport zoom.
+
+    const PageScaleConstraints& constraints = m_pageScaleConstraintsSet.pageDefinedConstraints();
+
+    return fixedLayoutSize().width == m_size.width
+        || (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);
 }
 
 } // namespace WebKit