Issue 23592002: Fix issue when the family name is reused among multiple families.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23592002: Fix issue when the family name is reused among multiple families. (Closed)

Created:
7 years, 3 months ago by djsollen

Modified:
7 years, 3 months ago

Reviewers:
Xianzhu, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix issue when the family name is reused among multiple families. BUG=chromium:274117 R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=10942

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/ports/SkFontConfigInterface_android.cpp	View		1 chunk	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

lgtm https://codereview.chromium.org/23592002/diff/1/src/ports/SkFontConfigInterface_android.cpp File src/ports/SkFontConfigInterface_android.cpp (right): https://codereview.chromium.org/23592002/diff/1/src/ports/SkFontConfigInterface_android.cpp#newcode186 src/ports/SkFontConfigInterface_android.cpp:186: if (familyNameDict.find(tolc.lc())) { I think a block-comment here ...

7 years, 3 months ago (2013-08-27 17:23:39 UTC) #2

djsollen

7 years, 3 months ago (2013-08-27 17:40:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r10942 (presubmit successful).

Expand Messages | Collapse Messages