Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2359173002: Remove WiFi link speed tracking from Android NetworkChangeNotifier (Closed)

Created:
4 years, 3 months ago by pauljensen
Modified:
4 years, 3 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WiFi link speed tracking from Android NetworkChangeNotifier Chrome has eschewed ACCESS_WIFI_STATE permission so this code is disabled. Chrome is also the only user of this NetworkChangeNotifier signal so remove the code as it is consequently dead. BUG=647691 R=jkarlin Committed: https://crrev.com/8788690b9a7d547bc55c0aa4bc54e3c230ca9391 Cr-Commit-Position: refs/heads/master@{#420692}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comment #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -85 lines) Patch
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 1 2 5 chunks +4 lines, -33 lines 0 comments Download
M net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java View 1 2 7 chunks +2 lines, -52 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
pauljensen
Josh, PTAL, thank you!
4 years, 3 months ago (2016-09-22 15:18:00 UTC) #1
jkarlin
lgtm with nit https://codereview.chromium.org/2359173002/diff/1/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java File net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java (left): https://codereview.chromium.org/2359173002/diff/1/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java#oldcode853 net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java:853: * max link speed. In cases ...
4 years, 3 months ago (2016-09-22 15:24:02 UTC) #2
pauljensen
https://codereview.chromium.org/2359173002/diff/1/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java File net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java (left): https://codereview.chromium.org/2359173002/diff/1/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java#oldcode853 net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java:853: * max link speed. In cases where more information ...
4 years, 3 months ago (2016-09-23 02:32:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359173002/60001
4 years, 3 months ago (2016-09-23 17:52:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/35928) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 3 months ago (2016-09-23 17:56:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359173002/60001
4 years, 3 months ago (2016-09-23 18:30:46 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-23 19:26:52 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:29:53 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8788690b9a7d547bc55c0aa4bc54e3c230ca9391
Cr-Commit-Position: refs/heads/master@{#420692}

Powered by Google App Engine
This is Rietveld 408576698