Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: net/http/http_stream_factory_impl_job_controller.cc

Issue 2359153003: Minor cleanups in HttpStreamFactoryImpl and member classes. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job_controller.cc
diff --git a/net/http/http_stream_factory_impl_job_controller.cc b/net/http/http_stream_factory_impl_job_controller.cc
index 2ce5c9b542e8d70a066f64f251491c9beaeb1bb2..0452f84fc4525cb287939ea128c08c84feffa18d 100644
--- a/net/http/http_stream_factory_impl_job_controller.cc
+++ b/net/http/http_stream_factory_impl_job_controller.cc
@@ -4,6 +4,10 @@
#include "net/http/http_stream_factory_impl_job_controller.h"
+#include <memory>
+#include <string>
+#include <utility>
+
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
@@ -15,6 +19,7 @@
#include "net/log/net_log_event_type.h"
#include "net/proxy/proxy_server.h"
#include "net/spdy/spdy_session.h"
+#include "url/url_constants.h"
namespace net {
@@ -642,7 +647,7 @@ void HttpStreamFactoryImpl::JobController::CreateJobs(
<< alternative_service.host_port_pair().host()
<< " port: " << alternative_service.host_port_pair().port() << ")";
- DCHECK(!request_info.url.SchemeIs("ftp"));
+ DCHECK(!request_info.url.SchemeIs(url::kFtpScheme));
HostPortPair alternative_destination(alternative_service.host_port_pair());
ignore_result(
ApplyHostMappingRules(request_info.url, &alternative_destination));
@@ -877,7 +882,7 @@ HttpStreamFactoryImpl::JobController::GetAlternativeServiceForInternal(
HttpStreamRequest::StreamType stream_type) {
GURL original_url = request_info.url;
- if (!original_url.SchemeIs("https"))
+ if (!original_url.SchemeIs(url::kHttpsScheme))
return AlternativeService();
url::SchemeHostPort origin(original_url);
@@ -955,7 +960,7 @@ HttpStreamFactoryImpl::JobController::GetAlternativeServiceForInternal(
if (session_->quic_stream_factory()->IsQuicDisabled())
continue;
- if (!original_url.SchemeIs("https"))
+ if (!original_url.SchemeIs(url::kHttpsScheme))
continue;
// Check whether there is an existing QUIC session to use for this origin.
« net/http/http_stream_factory_impl_job.cc ('K') | « net/http/http_stream_factory_impl_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698