[turbofan] Remove the representation dimension from Type.

[turbofan] Remove the representation dimension from Type.

BUG=

Committed: https://crrev.com/d52451ec8601a7ed426e950d6061398ef0cdf7fa
Cr-Commit-Position: refs/heads/master@{#39641}

[mvstanton, 2016-09-22 13:34:08]

mvstanton@chromium.org changed reviewers:
+ jarin@chromium.org

[mvstanton, 2016-09-22 13:34:09]

Hi Jaro,
This CL removes the representation dimension. Tests seem okay because I already
removed usages. Have a look, thanks!
--Mike

[mvstanton, 2016-09-22 13:35:29]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 13:35:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 14:21:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 14:21:18]

Dry run: This issue passed the CQ dry run.

[Jarin, 2016-09-22 15:27:39]

lgtm. Thanks!

https://codereview.chromium.org/2359153002/diff/20001/src/compiler/types.cc
File src/compiler/types.cc (right):

https://codereview.chromium.org/2359153002/diff/20001/src/compiler/types.cc#n...
src/compiler/types.cc:286: // TODO(mvstanton): if it's a smi can I make this
SignedSmall()?
No need to, Lub will take care of this.

https://codereview.chromium.org/2359153002/diff/20001/src/compiler/types.h
File src/compiler/types.h (right):

https://codereview.chromium.org/2359153002/diff/20001/src/compiler/types.h#ne...
src/compiler/types.h:109: #define SEMANTIC(k)       ((k) &
BitsetType::kSemantic)
I think this can also go away, but it is ok to remove this later.

[mvstanton, 2016-09-22 18:03:37]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-09-22 18:03:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2359153002/#ps40001
(title: "Code comments.")

[commit-bot: I haz the power, 2016-09-22 18:03:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-09-22 18:16:31]

Thanks Jaro, uploadin'...

https://codereview.chromium.org/2359153002/diff/20001/src/compiler/types.cc
File src/compiler/types.cc (right):

https://codereview.chromium.org/2359153002/diff/20001/src/compiler/types.cc#n...
src/compiler/types.cc:286: // TODO(mvstanton): if it's a smi can I make this
SignedSmall()?
On 2016/09/22 15:27:39, Jarin wrote:
> No need to, Lub will take care of this.

Acknowledged.

https://codereview.chromium.org/2359153002/diff/20001/src/compiler/types.h
File src/compiler/types.h (right):

https://codereview.chromium.org/2359153002/diff/20001/src/compiler/types.h#ne...
src/compiler/types.h:109: #define SEMANTIC(k)       ((k) &
BitsetType::kSemantic)
On 2016/09/22 15:27:39, Jarin wrote:
> I think this can also go away, but it is ok to remove this later.

Cool, I already have the follow up CL coming...

[commit-bot: I haz the power, 2016-09-22 18:35:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-22 18:35:28]

Description was changed from

==========
[turbofan] Remove the representation dimension from Type.

BUG=
==========

to

==========
[turbofan] Remove the representation dimension from Type.

BUG=

Committed: https://crrev.com/d52451ec8601a7ed426e950d6061398ef0cdf7fa
Cr-Commit-Position: refs/heads/master@{#39641}
==========

[commit-bot: I haz the power, 2016-09-22 18:35:30]

Patchset 3 (id:??) landed as
https://crrev.com/d52451ec8601a7ed426e950d6061398ef0cdf7fa
Cr-Commit-Position: refs/heads/master@{#39641}