Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2359133003: Fix effect mapping computation for displacement-map w/ negative scale (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr., Stephen White
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix effect mapping computation for displacement-map w/ negative scale When scale is negative, the displacement will be in the opposite direction. Hence we need to only use the magnitude of the scale when computing the effect of the filter. BUG=641854 Committed: https://crrev.com/b5be3c886b80b2a7b0db0714e2ae1a1cb154bf3d Cr-Commit-Position: refs/heads/master@{#420396}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
fs
4 years, 3 months ago (2016-09-22 17:11:46 UTC) #6
Stephen White
LGTM
4 years, 3 months ago (2016-09-22 17:30:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359133003/1
4 years, 3 months ago (2016-09-22 17:54:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 18:07:03 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 18:10:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5be3c886b80b2a7b0db0714e2ae1a1cb154bf3d
Cr-Commit-Position: refs/heads/master@{#420396}

Powered by Google App Engine
This is Rietveld 408576698