Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2359123002: Revert of Update pixel test expectation and add new worker tests (Closed)

Created:
4 years, 3 months ago by Adam Rice
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update pixel test expectation and add new worker tests (patchset #7 id:120001 of https://codereview.chromium.org/2358833002/ ) Reason for revert: Appears to have broken pixel_tests on Win7 Release (NVIDIA) and Linux Release (NVIDIA) bots. Original issue's description: > Update pixel test expectation and add new worker tests > > In the previous CL: https://codereview.chromium.org/2328463004/ where > the commit() function is implemented, we add a new pixel test and put its > expectation to fail. Now that the reference image has been generated on > all GPU waterfall bots, it is time to update the expectation. > > This CL also adds a new test to make sure that WebGL's commit() > is behaving as expected on a worker thread. > > BUG=563852 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Committed: https://crrev.com/ec8349cfc41f8abb93e5b60561b3fbe3d541fb05 > Cr-Commit-Position: refs/heads/master@{#420304} TBR=junov@chromium.org,kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,xidachen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563852 Committed: https://crrev.com/7968aade49c199e9168b88c8fec330287da80c41 Cr-Commit-Position: refs/heads/master@{#420313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -79 lines) Patch
D content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html View 1 chunk +0 lines, -68 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Adam Rice
Created Revert of Update pixel test expectation and add new worker tests
4 years, 3 months ago (2016-09-22 12:48:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359123002/1
4 years, 3 months ago (2016-09-22 12:48:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 12:49:39 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 12:51:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7968aade49c199e9168b88c8fec330287da80c41
Cr-Commit-Position: refs/heads/master@{#420313}

Powered by Google App Engine
This is Rietveld 408576698