Issue 23591068: Generate toCSSFooValue() for CSSAspectRatioValue, CSSBorderImageSliceValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23591068: Generate toCSSFooValue() for CSSAspectRatioValue, CSSBorderImageSliceValue (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive

Modified:
7 years, 3 months ago

Reviewers:
tkent

CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Generate toCSSFooValue() for CSSAspectRatioValue, CSSBorderImageSliceValue and CSSValueList This cl cleanup static_cast<CSS*Value> type cast using DEFINE_CSS_VALUE_TYPE_CASTS. toCSSFooValue() will help to detect bad-casts as well as improve readibility. CSSAspectRatioValue, CSSBorderImageSliceValue are covered by this cl. Additionally, CSSValueList uses DEFINE_CSS_VALUE_TYPE_CASTS instead of manual inline functions. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158297

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -19 lines)			Patch
M	Source/core/css/CSSAspectRatioValue.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSBorderImageSliceValue.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSToStyleMap.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSValue.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSValueList.h	View	1 chunk	+1 line, -14 lines	0 comments	Download
M	Source/core/css/MediaQueryEvaluator.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gyuyoung-inactive

Add tkent to reviewer. tkent, the style check patch for toFoo was reverted. So, I ...

7 years, 3 months ago (2013-09-24 13:37:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23591068/1

7 years, 3 months ago (2013-09-24 23:02:08 UTC) #3

Message was sent while issue was closed.

Change committed as 158297

Expand Messages | Collapse Messages