pkg/scheduled_test/lib/scheduled_server.dart - Issue 23591061: Make package:scheduled_test throw ScheduledServerErrors, not strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/scheduled_test/lib/scheduled_server.dart

Issue 23591061: Make package:scheduled_test throw ScheduledServerErrors, not strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove type check on exception. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/scheduled_test/lib/scheduled_server.dart

diff --git a/pkg/scheduled_test/lib/scheduled_server.dart b/pkg/scheduled_test/lib/scheduled_server.dart

index 8c1ad815da2ef4894087c5fcc9b38ad32212e655..743e2b63b2ec679b0d2313a2f891e89537335a39 100644

--- a/pkg/scheduled_test/lib/scheduled_server.dart

+++ b/pkg/scheduled_test/lib/scheduled_server.dart

@@ -91,8 +91,8 @@ class ScheduledServer {

void _handleRequest(HttpRequest request) {

wrapFuture(new Future.sync(() {

if (_handlers.isEmpty) {

- throw "'$description' received ${request.method} ${request.uri.path} "

- "when no more requests were expected.";

+ fail("'$description' received ${request.method} ${request.uri.path} "

+ "when no more requests were expected.");

}

return _handlers.removeFirst().fn(request);

}).catchError((e) {

« no previous file with comments | « pkg/pkg.status ('k') | pkg/scheduled_test/lib/src/scheduled_server/handler.dart » ('j') | no next file with comments »