Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: ui/base/l10n/l10n_util_internal.h

Issue 23591040: Use ICU for string pluralization in the extension permission dialog. (Closed) Base URL: http://git.chromium.org/chromium/src.git@gtk-extension-install-dialog
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/l10n/l10n_util_internal.h
diff --git a/ui/base/l10n/l10n_util_internal.h b/ui/base/l10n/l10n_util_internal.h
new file mode 100644
index 0000000000000000000000000000000000000000..ce310549dce1e4cbb572bb69b5c7fbecb164a71e
--- /dev/null
+++ b/ui/base/l10n/l10n_util_internal.h
@@ -0,0 +1,29 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file contains utility functions for dealing with localized content that
+// expose ICU types in their interface.
tony 2013/09/20 16:56:44 Nit: I have a slight preference for a file name li
Sam McNally 2013/09/22 22:53:03 Done.
+
+#ifndef UI_BASE_L10N_L10N_UTIL_INTERNAL_H_
+#define UI_BASE_L10N_L10N_UTIL_INTERNAL_H_
+
+#include <string>
+#include <vector>
+
+#include "base/memory/scoped_ptr.h"
+#include "third_party/icu/source/i18n/unicode/plurfmt.h"
+#include "third_party/icu/source/i18n/unicode/plurrule.h"
+
+namespace l10n_util {
+
+// Returns a PluralRules for the current locale.
+scoped_ptr<icu::PluralRules> BuildPluralRules();
+
+// Returns a PluralFormat from |message_ids|. |message_ids| must be size 6 and
+// in order: default, singular, zero, two, few, many.
+scoped_ptr<icu::PluralFormat> BuildPluralFormat(std::vector<int> message_ids);
tony 2013/09/20 16:56:44 |message_ids| should be a const ref.
Sam McNally 2013/09/22 22:53:03 Done.
+
+} // namespace l10n_util
+
+#endif // UI_BASE_L10N_L10N_UTIL_INTERNAL_H_

Powered by Google App Engine
This is Rietveld 408576698