Use ICU for string pluralization in the extension permission dialog.

chrome/browser/extensions/extension_install_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_prompt.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 22 matching lines @@
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "extensions/common/extension_resource.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/url_pattern.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
+#include "third_party/icu/source/i18n/unicode/plurfmt.h"
+#include "third_party/icu/source/i18n/unicode/plurrule.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"
 
 using extensions::BundleInstaller;
 using extensions::Extension;
 using extensions::Manifest;
 using extensions::PermissionSet;
 
 namespace {
@@ skipping 287 matching lines @@
 
 string16 ExtensionInstallPrompt::Prompt::GetPermissionsHeading() const {
   return l10n_util::GetStringUTF16(kPermissionsHeaderIds[type_]);
 }
 
 string16 ExtensionInstallPrompt::Prompt::GetOAuthHeading() const {
   return l10n_util::GetStringFUTF16(kOAuthHeaderIds[type_], oauth_user_name_);
 }
 
 string16 ExtensionInstallPrompt::Prompt::GetRetainedFilesHeading() const {
-  return l10n_util::GetStringFUTF16(
-      IDS_EXTENSION_PROMPT_RETAINED_FILES,
-      base::IntToString16(GetRetainedFileCount()));
+  const icu::UnicodeString kKeywords[] = {

[tony, 2013/09/19 17:00:40]

This is basically copied from TimeFormatter::BuildFormats().  Please move this
into a helper function in ui/base/l10n/.  Maybe in l10n_util?

[Sam McNally, 2013/09/20 04:10:55]

Done.

+      UNICODE_STRING_SIMPLE("other"),
+      UNICODE_STRING_SIMPLE("one"),
+      UNICODE_STRING_SIMPLE("zero"),
+      UNICODE_STRING_SIMPLE("two"),
+      UNICODE_STRING_SIMPLE("few"),
+      UNICODE_STRING_SIMPLE("many"),
+  };
+  UErrorCode err = U_ZERO_ERROR;
+  scoped_ptr<icu::PluralRules> rules(
+      icu::PluralRules::forLocale(icu::Locale::getDefault(), err));
+  if (U_FAILURE(err)) {
+    err = U_ZERO_ERROR;
+    icu::UnicodeString fallback_rules("one: n is 1", -1, US_INV);
+    rules.reset(icu::PluralRules::createRules(fallback_rules, err));
+    DCHECK(U_SUCCESS(err));
+  }
+
+  const int kRetainedFilesMessageIDs[6] = {
+      IDS_EXTENSION_PROMPT_RETAINED_FILES_DEFAULT,
+      IDS_EXTENSION_PROMPT_RETAINED_FILE_SINGULAR,
+      IDS_EXTENSION_PROMPT_RETAINED_FILES_ZERO,
+      IDS_EXTENSION_PROMPT_RETAINED_FILES_TWO,
+      IDS_EXTENSION_PROMPT_RETAINED_FILES_FEW,
+      IDS_EXTENSION_PROMPT_RETAINED_FILES_MANY,
+  };
+
+  icu::UnicodeString pattern;
+  for (size_t i = 0; i < arraysize(kKeywords); ++i) {
+    int msg_id = kRetainedFilesMessageIDs[i];
+    std::string sub_pattern = l10n_util::GetStringUTF8(msg_id);
+    // NA means this keyword is not used in the current locale.
+    // Even if a translator translated for this keyword, we do not
+    // use it unless it's 'other' (i=0) or it's defined in the rules
+    // for the current locale. Special-casing of 'other' will be removed
+    // once ICU's isKeyword is fixed to return true for isKeyword('other').
+    if (sub_pattern.compare("NA") != 0 &&
+        (i == 0 || rules->isKeyword(kKeywords[i]))) {
+      pattern += kKeywords[i];
+      pattern += UNICODE_STRING_SIMPLE("{");
+      pattern += icu::UnicodeString(sub_pattern.c_str(), "UTF-8");
+      pattern += UNICODE_STRING_SIMPLE("}");
+    }
+  }
+  icu::PluralFormat format(*rules, pattern, err);
+  if (!U_SUCCESS(err)) {
+    return l10n_util::GetStringFUTF16(
+        IDS_EXTENSION_PROMPT_RETAINED_FILES_FALLBACK,
+        UTF8ToUTF16(base::IntToString(GetRetainedFileCount())));
+  }
+
+  icu::UnicodeString retained_files_string =
+      format.format(static_cast<int>(GetRetainedFileCount()), err);
+  DCHECK(U_SUCCESS(err));
+  int capacity = retained_files_string.length() + 1;
+  DCHECK_GT(capacity, 1);
+  string16 result;
+  retained_files_string.extract(
+      static_cast<UChar*>(WriteInto(&result, capacity)), capacity, err);
+  DCHECK(U_SUCCESS(err));
+  return result;
 }
 
 bool ExtensionInstallPrompt::Prompt::ShouldShowPermissions() const {
   return GetPermissionCount() > 0 || type_ == POST_INSTALL_PERMISSIONS_PROMPT;
 }
 
 void ExtensionInstallPrompt::Prompt::AppendRatingStars(
     StarAppender appender, void* data) const {
   CHECK(appender);
   CHECK_EQ(INLINE_INSTALL_PROMPT, type_);
@@ skipping 437 matching lines @@
   }
 
   if (AutoConfirmPrompt(delegate_))
     return;
 
   if (show_dialog_callback_.is_null())
     GetDefaultShowDialogCallback().Run(show_params_, delegate_, prompt_);
   else
     show_dialog_callback_.Run(show_params_, delegate_, prompt_);
 }