Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2359103002: WebRTCStatsReport::copyHandle and getStats added (Closed)

Created:
4 years, 3 months ago by hbos_chromium
Modified:
4 years, 2 months ago
Reviewers:
Guido Urdaneta, foolip
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, dglazkov+blink, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRTCStatsReport::copyHandle and getStats added. These will be used in a follow-up CL. BUG=chromium:627816 Committed: https://crrev.com/4e0a777e8d3c7d7caefbf9d4e5c0181d0d92e869 Cr-Commit-Position: refs/heads/master@{#420315}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M content/renderer/media/webrtc/rtc_stats.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc/rtc_stats.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCStats.h View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 23 (14 generated)
hbos_chromium
PTAL guidou
4 years, 2 months ago (2016-09-22 12:08:16 UTC) #5
Guido Urdaneta
lgtm
4 years, 2 months ago (2016-09-22 12:12:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359103002/1
4 years, 2 months ago (2016-09-22 12:21:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/264642)
4 years, 2 months ago (2016-09-22 12:29:57 UTC) #14
hbos_chromium
Please take a look, foolip.
4 years, 2 months ago (2016-09-22 12:36:33 UTC) #16
foolip
rs lgtm https://codereview.chromium.org/2359103002/diff/1/third_party/WebKit/public/platform/WebRTCStats.h File third_party/WebKit/public/platform/WebRTCStats.h (right): https://codereview.chromium.org/2359103002/diff/1/third_party/WebKit/public/platform/WebRTCStats.h#newcode45 third_party/WebKit/public/platform/WebRTCStats.h:45: // Gets stats object by |id|, or ...
4 years, 2 months ago (2016-09-22 12:44:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359103002/1
4 years, 2 months ago (2016-09-22 12:47:56 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-22 12:53:02 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 12:56:08 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e0a777e8d3c7d7caefbf9d4e5c0181d0d92e869
Cr-Commit-Position: refs/heads/master@{#420315}

Powered by Google App Engine
This is Rietveld 408576698