cc/output/shader.cc - Issue 23591027: Allow NOLINT to skip the std::abs PRESUBMIT check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/shader.cc

Issue 23591027: Allow NOLINT to skip the std::abs PRESUBMIT check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/shader.cc

diff --git a/cc/output/shader.cc b/cc/output/shader.cc

index 8ab2114555fbbfec11372bb4a9987d495708177a..ea469d2df247e213aea5bb80dce312e986b5d54d 100644

--- a/cc/output/shader.cc

+++ b/cc/output/shader.cc

@@ -1597,7 +1597,7 @@ std::string FragmentShaderCheckerboard::GetShaderString(

vec2 texCoord =

clamp(v_texCoord, 0.0, 1.0) * texTransform.zw + texTransform.xy;

vec2 coord = mod(floor(texCoord * frequency * 2.0), 2.0);

- float picker = abs(coord.x - coord.y);

+ float picker = abs(coord.x - coord.y); // NOLINT

enne (OOO) 2013/09/05 01:00:40 optional style nit: two spaces before the comment

gl_FragColor = mix(color1, color2, picker) * alpha;

}

); // NOLINT(whitespace/parens)

« cc/PRESUBMIT.py ('K') | « cc/PRESUBMIT.py ('k') | no next file » | no next file with comments »