Issue 23591020: Add toHTMLDocument() convenience methods that take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23591020: Add toHTMLDocument() convenience methods that take a reference (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add toHTMLDocument() convenience methods that take a reference Add toHTMLDocument() convenience methods that take a reference as several call sites have a Document reference, not a pointer. This avoids having to convert the reference into a pointer. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157046

Patch Set 1 #

Patch Set 2 : Improve casting #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -14 lines)			Patch
M	Source/core/dom/Element.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLDocument.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLIFrameElement.cpp	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLObjectElement.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23591020/1005

7 years, 3 months ago (2013-09-01 14:52:38 UTC) #3

Message was sent while issue was closed.

Change committed as 157046

Expand Messages | Collapse Messages