Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 23591017: Update find_unused_resources.py to ignore third party resources. (Closed)

Created:
7 years, 3 months ago by newt (away)
Modified:
7 years, 3 months ago
Reviewers:
cjhopman, bulach
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Update find_unused_resources.py to ignore third party resources. find_unused_resources.py thinks that resources defined in third party libraries are all unused. This updates the script to ignore those resources. BUG=149661 R=bulach@chromium.org, cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221769

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : hide attrs and ids #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -32 lines) Patch
M tools/android/find_unused_resources.py View 1 2 2 chunks +51 lines, -32 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
newt (away)
could you take a look? thanks!
7 years, 3 months ago (2013-08-30 22:55:37 UTC) #1
newt (away)
ping?
7 years, 3 months ago (2013-09-05 03:35:18 UTC) #2
cjhopman
lgtm https://codereview.chromium.org/23591017/diff/5001/tools/android/find_unused_resources.py File tools/android/find_unused_resources.py (right): https://codereview.chromium.org/23591017/diff/5001/tools/android/find_unused_resources.py#newcode32 tools/android/find_unused_resources.py:32: data_type, res_type, name, _ = line.split(None, 3) what's ...
7 years, 3 months ago (2013-09-06 00:38:08 UTC) #3
newt (away)
Thanks! +bulach for OWNER goodness https://codereview.chromium.org/23591017/diff/5001/tools/android/find_unused_resources.py File tools/android/find_unused_resources.py (right): https://codereview.chromium.org/23591017/diff/5001/tools/android/find_unused_resources.py#newcode32 tools/android/find_unused_resources.py:32: data_type, res_type, name, _ ...
7 years, 3 months ago (2013-09-06 00:49:49 UTC) #4
bulach
lgtm, thanks!
7 years, 3 months ago (2013-09-06 12:24:59 UTC) #5
newt (away)
7 years, 3 months ago (2013-09-06 20:30:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r221769 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698