chrome/renderer/resources/extensions/web_view.js - Issue 23591016: BrowserPlugin/WebView - Move plugin lifetime to DOM (Chromium-side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 23591016: BrowserPlugin/WebView - Move plugin lifetime to DOM (Chromium-side) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase CL. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/web_view.js

diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js

index 47dafb181b216c0be3499d1b91bd6c1ad744e36e..3efe3e60ac197d5638d9458a410c1afd0ae46cc1 100644

--- a/chrome/renderer/resources/extensions/web_view.js

+++ b/chrome/renderer/resources/extensions/web_view.js

@@ -908,8 +908,8 @@ function registerBrowserPluginElement() {

var proto = Object.create(HTMLObjectElement.prototype);

proto.createdCallback = function() {

- this.setAttribute('type', 'application/browser-plugin');

// The <object> node fills in the <webview> container.

+ this.setAttribute('type', 'application/browser-plugin');

this.style.width = '100%';

this.style.height = '100%';

};