Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 23591010: Fix bug with ContentViewClient (Closed)

Created:
7 years, 3 months ago by David Trainor- moved to gerrit
Modified:
7 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Visibility:
Public.

Description

Fix bug with ContentViewClient - We were clearing ContentViewClient by accident, making subsequent init calls not bind the right one. BUG=277135 NOTRY=true R=tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220082

Patch Set 1 #

Patch Set 2 : Cleanup delegate too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/TabBase.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
David Trainor- moved to gerrit
ptal
7 years, 3 months ago (2013-08-28 20:32:07 UTC) #1
Ted C
lgtm
7 years, 3 months ago (2013-08-28 20:33:21 UTC) #2
David Trainor- moved to gerrit
7 years, 3 months ago (2013-08-28 20:35:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r220082 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698