Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: scripts/master/factory/chromium_commands.py

Issue 23591008: Add mini_installer tests to the Chromium build infrastructure. (Closed) Base URL: http://src.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/factory/chromium_commands.py
===================================================================
--- scripts/master/factory/chromium_commands.py (revision 219965)
+++ scripts/master/factory/chromium_commands.py (working copy)
@@ -98,6 +98,10 @@
self._nacl_integration_tester_tool = J(
'src', 'chrome', 'test', 'nacl_test_injection',
'buildbot_nacl_integration.py')
+ self._mini_installer_tests_runner = J('src', 'chrome', 'test',
+ 'mini_installer', 'test_installer.py')
+ self._mini_installer_tests = J('src', 'chrome', 'test', 'mini_installer',
+ 'config', 'config.config')
# chrome_staging directory, relative to the build directory.
self._staging_dir = self.PathJoin('..', 'chrome_staging')
@@ -1595,6 +1599,14 @@
cmd_name='browser_tests',
cmd_options=cmd_options)
+ def AddMiniInstallerTestStep(self, factory_properties):
+ if self._target_platform == 'win32' and self._target == 'Release':
csharp 2013/08/28 19:25:00 Why this if statement? Does this test not sense in
sukolsak 2013/08/28 19:46:19 Fixed. This should also work with 64-bit builds. I
+ cmd = [self._python, self._mini_installer_tests_runner,
+ self._mini_installer_tests]
+ self.AddTestStep(chromium_step.AnnotatedCommand, 'test_mini_installer',
+ cmd, halt_on_failure=True, timeout=600,
+ do_step_if=self.TestStepFilter)
+
def AddChromebotServer(self, factory_properties=None):
"""Add steps to run Chromebot script for server.

Powered by Google App Engine
This is Rietveld 408576698