Add mini_installer tests to the Chromium build infrastructure.

scripts/master/factory/chromium_commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Set of utilities to add commands to a buildbot factory.
 
 This is based on commands.py and adds chromium-specific commands."""
 
 import logging
 import os
@@ skipping 80 matching lines @@
     self._check_licenses_tool = J('src', 'tools', 'checklicenses',
                                   'checklicenses.py')
     self._posix_memory_tests_runner = J('src', 'tools', 'valgrind',
                                         'chrome_tests.sh')
     self._win_memory_tests_runner = J('src', 'tools', 'valgrind',
                                       'chrome_tests.bat')
     self._heapcheck_tool = J('src', 'tools', 'heapcheck', 'chrome_tests.sh')
     self._nacl_integration_tester_tool = J(
         'src', 'chrome', 'test', 'nacl_test_injection',
         'buildbot_nacl_integration.py')
+    self._mini_installer_tests_runner = J('src', 'chrome', 'test',
+                                          'mini_installer', 'test_installer.py')
+    self._mini_installer_tests_config = J('src', 'chrome', 'test',
+                                          'mini_installer', 'config',
+                                          'config.config')

[Nico, 2013/12/14 00:21:40]

Do you intend to have several configs in the future? Why doesn't test_install.py
just pick up the config from config/config.config relative to itself?

[robertshield, 2014/01/23 20:35:51]

I'm looking into resurrecting these tests and moving them from the fyi waterfall
to the main waterfall. Came across your comment. Being able to use different
configs is useful during development, but I can see why it would be useful to
have the runner look in config/config.config by default.  I'll send you a patch
in a bit.

     # chrome_staging directory, relative to the build directory.
     self._staging_dir = self.PathJoin('..', 'chrome_staging')
 
     # The _update_scripts_command will be run in the _update_scripts_dir to
     # udpate the slave's own script checkout.
     self._update_scripts_dir = '..'
     self._update_scripts_command = [
         chromium_utils.GetGClientCommand(self._target_platform),
         'sync', '--verbose']
 
@@ skipping 1477 matching lines @@
 
   def AddWebRtcPerfManualBrowserTests(self, factory_properties=None):
     cmd_options = ['--run-manual', '--ui-test-action-max-timeout=300000']
     self.AddAnnotatedPerfStep(test_name='webrtc_manual_browser_tests',
                               gtest_filter="Webrtc*",
                               log_type='graphing',
                               factory_properties=factory_properties,
                               cmd_name='browser_tests',
                               cmd_options=cmd_options)
 
+  def AddMiniInstallerTestStep(self, factory_properties):
+    cmd = [self._python, self._mini_installer_tests_runner,
+           self._mini_installer_tests_config]
+    self.AddTestStep(chromium_step.AnnotatedCommand, 'test_mini_installer', cmd,
+                     halt_on_failure=True, timeout=600,
+                     do_step_if=self.TestStepFilter)
+
   def AddChromebotServer(self, factory_properties=None):
     """Add steps to run Chromebot script for server.
 
     This expects build property to be set with Chromium build number, which
     is set by SetBuildPropertyShellCommand in GetBuildForChromebot step.
 
     Args:
       client_os: Target client OS (win or linux).
       server_port: Port for client/server communication.
       timeout: Max time (secs) to run Chromebot server script.
@@ skipping 201 matching lines @@
   return '%s/%s/%s' % (config.Master.archive_url, archive_type, builder_name)
 
 
 def _GetSnapshotUrl(factory_properties=None, builder_name='%(build_name)s'):
   if not factory_properties or 'gs_bucket' not in factory_properties:
     return (_GetArchiveUrl('snapshots', builder_name), None)
   gs_bucket = factory_properties['gs_bucket']
   gs_bucket = re.sub(r'^gs://', 'http://commondatastorage.googleapis.com/',
                      gs_bucket)
   return ('%s/index.html?path=%s' % (gs_bucket, builder_name), '/')