Issue 23591006: Use V8_OS_* variables for platform detection in the sampler code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23591006: Use V8_OS_* variables for platform detection in the sampler code (Closed)

Created:
7 years, 3 months ago by yurys

Modified:
7 years, 3 months ago

Reviewers:
Benedikt Meurer, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use V8_OS_* variables for platform detection in the sampler code BUG=None Committed: http://code.google.com/p/v8/source/detail?r=16415

Patch Set 2 : Comment addressed #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -22 lines)			Patch
	M	src/sampler.cc	View	1	13 chunks	+20 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

LGTM with comment https://codereview.chromium.org/23591006/diff/1/src/sampler.cc File src/sampler.cc (right): https://codereview.chromium.org/23591006/diff/1/src/sampler.cc#newcode316 src/sampler.cc:316: #if V8_OS_LINUX || V8_OS_ANDROID V8_OS_ANDROID implies ...

7 years, 3 months ago (2013-08-29 09:25:29 UTC) #2

yurys

7 years, 3 months ago (2013-08-29 09:30:05 UTC) #3

https://codereview.chromium.org/23591006/diff/1/src/sampler.cc
File src/sampler.cc (right):

https://codereview.chromium.org/23591006/diff/1/src/sampler.cc#newcode316
src/sampler.cc:316: #if V8_OS_LINUX || V8_OS_ANDROID
On 2013/08/29 09:25:29, Benedikt Meurer wrote:
> V8_OS_ANDROID implies V8_OS_LINUX, so you don't need the extra test for
> V8_OS_ANDROID here.

Done.

Expand Messages | Collapse Messages

Issue 23591006: Use V8_OS_* variables for platform detection in the sampler code (Closed)

Description

Patch Set 1 #

Patch Set 2 : Comment addressed #

Messages