Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPaintProperties.h

Issue 2359063002: Add static root property tree nodes [spv2] (Closed)
Patch Set: Restore PaintPropertyTreeGraphBuilder root node printing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
diff --git a/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h b/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
index 026c5eceb156f1b8171764fc1aeddb19f4004363..0e47c7782c4516f1107ac74f67890ad6a2fd1bec 100644
--- a/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
+++ b/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
@@ -20,6 +20,21 @@
namespace blink {
+// A complete set of paint properties including those that are inherited from other objects.
+struct PropertyTreeState {
+ PropertyTreeState(const TransformPaintPropertyNode* transformState,
+ const ClipPaintPropertyNode* clipState, const EffectPaintPropertyNode* effectState,
+ const ScrollPaintPropertyNode* scrollState)
+ : transform(transformState), clip(clipState), effect(effectState), scroll(scrollState)
+ {
+ DCHECK(transform && clip && effect && scroll);
+ }
+ const TransformPaintPropertyNode* transform;
+ const ClipPaintPropertyNode* clip;
+ const EffectPaintPropertyNode* effect;
+ const ScrollPaintPropertyNode* scroll;
+};
+
// This class stores property tree related information associated with a LayoutObject.
// Currently there are two groups of information:
// 1. The set of property nodes created locally by this LayoutObject.
@@ -79,6 +94,7 @@ public:
// baked into in the context here. However for properties that affects only children,
// for example, perspective and overflow clip, those should be applied by the painter
// at the right painting step.
+ // TODO(pdr): Refactor this to use PropertyTreeState.
struct LocalBorderBoxProperties {
LayoutPoint paintOffset;
GeometryPropertyTreeState geometryPropertyTreeState;

Powered by Google App Engine
This is Rietveld 408576698