Add static root property tree nodes [spv2]

third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutTreeAsText.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/paint/ObjectPaintProperties.h"
 #include "core/paint/PaintPropertyTreePrinter.h"
 #include "platform/graphics/paint/GeometryMapper.h"
@@ skipping 22 matching lines @@
 
     void loadTestData(const char* fileName)
     {
         String fullPath = testing::blinkRootDir();
         fullPath.append("/Source/core/paint/test_data/");
         fullPath.append(fileName);
         RefPtr<SharedBuffer> inputBuffer = testing::readFromFile(fullPath);
         setBodyInnerHTML(String(inputBuffer->data(), inputBuffer->size()));
     }
 
-    const TransformPaintPropertyNode* rootTransform()
-    {
-        FrameView* frameView = document().view();
-        if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
-            return frameView->layoutView()->objectPaintProperties()->paintOffsetTranslation();
-        return frameView->rootTransform();
-    }
-
-    const ClipPaintPropertyNode* rootClip()
-    {
-        if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
-            return document().view()->layoutView()->objectPaintProperties()->localBorderBoxProperties()->geometryPropertyTreeState.clip.get();
-        return document().view()->rootClip();
-    }
-
-    const ScrollPaintPropertyNode* rootScroll()
-    {
-        FrameView* frameView = document().view();
-        if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
-            return frameView->layoutView()->objectPaintProperties()->scroll();
-        return frameView->rootScroll();
-    }
-
     const TransformPaintPropertyNode* framePreTranslation()
     {
         FrameView* frameView = document().view();
         if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
             return frameView->layoutView()->objectPaintProperties()->paintOffsetTranslation();
         return frameView->preTranslation();
     }
 
     const TransformPaintPropertyNode* frameScrollTranslation()
     {
@@ skipping 87 matching lines @@
     Element* target1 = document().getElementById("target1");
     const ObjectPaintProperties* target1Properties = target1->layoutObject()->objectPaintProperties();
     EXPECT_EQ(TransformationMatrix().translate(200, 150), target1Properties->paintOffsetTranslation()->matrix());
     EXPECT_EQ(framePreTranslation(), target1Properties->paintOffsetTranslation()->parent());
     EXPECT_EQ(target1Properties->paintOffsetTranslation(), target1Properties->overflowClip()->localTransformSpace());
     EXPECT_EQ(FloatRoundedRect(0, 0, 100, 100), target1Properties->overflowClip()->clipRect());
     // Likewise, it inherits clip from the viewport, skipping overflow clip of the scroller.
     EXPECT_EQ(frameContentClip(), target1Properties->overflowClip()->parent());
     // target1 should not have it's own scroll node and instead should inherit positionedScroll's.
     const ObjectPaintProperties* positionedScrollProperties = positionedScroll->layoutObject()->objectPaintProperties();
-    EXPECT_EQ(rootScroll(), positionedScrollProperties->scroll()->parent());
+    EXPECT_TRUE(positionedScrollProperties->scroll()->parent()->isRoot());
     EXPECT_EQ(TransformationMatrix().translate(0, -3), positionedScrollProperties->scroll()->scrollOffsetTranslation()->matrix());
     EXPECT_EQ(nullptr, target1Properties->scroll());
 
     CHECK_EXACT_VISUAL_RECT(LayoutRect(200, 150, 100, 100), target1->layoutObject(), frameView->layoutView());
 
     // target2 is a fixed-position element inside a transformed scrolling element.
     // It should be attached under the scrolled box of the transformed element.
     Element* target2 = document().getElementById("target2");
     const ObjectPaintProperties* target2Properties = target2->layoutObject()->objectPaintProperties();
     Element* scroller = document().getElementById("transformedScroll");
     const ObjectPaintProperties* scrollerProperties = scroller->layoutObject()->objectPaintProperties();
     EXPECT_EQ(TransformationMatrix().translate(200, 150), target2Properties->paintOffsetTranslation()->matrix());
     EXPECT_EQ(scrollerProperties->scrollTranslation(), target2Properties->paintOffsetTranslation()->parent());
     EXPECT_EQ(target2Properties->paintOffsetTranslation(), target2Properties->overflowClip()->localTransformSpace());
     EXPECT_EQ(FloatRoundedRect(0, 0, 100, 100), target2Properties->overflowClip()->clipRect());
     EXPECT_EQ(scrollerProperties->overflowClip(), target2Properties->overflowClip()->parent());
     // target2 should not have it's own scroll node and instead should inherit transformedScroll's.
     const ObjectPaintProperties* transformedScrollProperties = transformedScroll->layoutObject()->objectPaintProperties();
-    EXPECT_EQ(rootScroll(), transformedScrollProperties->scroll()->parent());
+    EXPECT_TRUE(transformedScrollProperties->scroll()->parent()->isRoot());
     EXPECT_EQ(TransformationMatrix().translate(0, -5), transformedScrollProperties->scroll()->scrollOffsetTranslation()->matrix());
     EXPECT_EQ(nullptr, target2Properties->scroll());
 
     CHECK_EXACT_VISUAL_RECT(LayoutRect(208, 153, 200, 100), target2->layoutObject(), frameView->layoutView());
 }
 
 TEST_P(PaintPropertyTreeBuilderTest, PositionAndScroll)
 {
     loadTestData("position-and-scroll.html");
 
@@ skipping 45 matching lines @@
 TEST_P(PaintPropertyTreeBuilderTest, FrameScrollingTraditional)
 {
     setBodyInnerHTML("<style> body { height: 10000px; } </style>");
 
     document().domWindow()->scrollTo(0, 100);
 
     FrameView* frameView = document().view();
     frameView->updateAllLifecyclePhases();
     EXPECT_EQ(TransformationMatrix(), framePreTranslation()->matrix());
     if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled())
-        EXPECT_EQ(rootTransform(), framePreTranslation()->parent());
-    EXPECT_EQ(nullptr, rootTransform()->parent());
+        EXPECT_TRUE(framePreTranslation()->parent()->isRoot());
+
     EXPECT_EQ(TransformationMatrix().translate(0, -100), frameScrollTranslation()->matrix());
     EXPECT_EQ(framePreTranslation(), frameScrollTranslation()->parent());
     EXPECT_EQ(framePreTranslation(), frameContentClip()->localTransformSpace());
     EXPECT_EQ(FloatRoundedRect(0, 0, 800, 600), frameContentClip()->clipRect());
-    EXPECT_EQ(rootClip(), frameContentClip()->parent());
-    if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled())
-        EXPECT_EQ(nullptr, rootClip()->parent());
+    EXPECT_TRUE(frameContentClip()->parent()->isRoot());
 
     LayoutViewItem layoutViewItem = document().layoutViewItem();
     const ObjectPaintProperties* layoutViewProperties = layoutViewItem.objectPaintProperties();
     // http://crbug.com/638415
     if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
         EXPECT_EQ(nullptr, layoutViewProperties->scrollTranslation());
         CHECK_EXACT_VISUAL_RECT(LayoutRect(8, 8, 784, 10000), document().body()->layoutObject(), frameView->layoutView());
     }
 }
 
@@ skipping 1497 matching lines @@
         "  <div class='forceScroll'></div>"
         "</div>");
 
     Element* overflowHidden = document().getElementById("overflowHidden");
     overflowHidden->setScrollTop(37);
 
     document().view()->updateAllLifecyclePhases();
 
     const ObjectPaintProperties* overflowHiddenScrollProperties = overflowHidden->layoutObject()->objectPaintProperties();
     // Because the frameView is does not scroll, overflowHidden's scroll should be under the root.
-    EXPECT_EQ(rootScroll(), overflowHiddenScrollProperties->scroll()->parent());
+    EXPECT_TRUE(overflowHiddenScrollProperties->scroll()->parent()->isRoot());
     EXPECT_EQ(TransformationMatrix().translate(0, -37), overflowHiddenScrollProperties->scroll()->scrollOffsetTranslation()->matrix());
     // This should match the overflow's dimensions.
     EXPECT_EQ(IntSize(5, 3), overflowHiddenScrollProperties->scroll()->clip());
     // The scrolling content's bounds should include both the overflow's dimensions (5x3) and the
     // 0x79 "forceScroll" object.
     EXPECT_EQ(IntSize(5, 79), overflowHiddenScrollProperties->scroll()->bounds());
     // Although overflow: hidden is programmatically scrollable, it is not user scrollable.
     EXPECT_FALSE(overflowHiddenScrollProperties->scroll()->userScrollableHorizontal());
     EXPECT_FALSE(overflowHiddenScrollProperties->scroll()->userScrollableVertical());
 }
@@ skipping 28 matching lines @@
 
     Element* overflowA = document().getElementById("overflowA");
     overflowA->setScrollTop(37);
     Element* overflowB = document().getElementById("overflowB");
     overflowB->setScrollTop(41);
 
     document().view()->updateAllLifecyclePhases();
 
     const ObjectPaintProperties* overflowAScrollProperties = overflowA->layoutObject()->objectPaintProperties();
     // Because the frameView is does not scroll, overflowA's scroll should be under the root.
-    EXPECT_EQ(rootScroll(), overflowAScrollProperties->scroll()->parent());
+    EXPECT_TRUE(overflowAScrollProperties->scroll()->parent()->isRoot());
     EXPECT_EQ(TransformationMatrix().translate(0, -37), overflowAScrollProperties->scroll()->scrollOffsetTranslation()->matrix());
     EXPECT_EQ(IntSize(5, 3), overflowAScrollProperties->scroll()->clip());
     // 107 is the forceScroll element plus the height of the overflow scroll child (overflowB).
     EXPECT_EQ(IntSize(9, 107), overflowAScrollProperties->scroll()->bounds());
     EXPECT_TRUE(overflowAScrollProperties->scroll()->userScrollableHorizontal());
     EXPECT_TRUE(overflowAScrollProperties->scroll()->userScrollableVertical());
 
     const ObjectPaintProperties* overflowBScrollProperties = overflowB->layoutObject()->objectPaintProperties();
     // The overflow child's scroll node should be a child of the parent's (overflowA) scroll node.
     EXPECT_EQ(overflowAScrollProperties->scroll(), overflowBScrollProperties->scroll()->parent());
@@ skipping 69 matching lines @@
 
     const ObjectPaintProperties* absposOverflowScrollProperties = absposOverflow->layoutObject()->objectPaintProperties();
     // The absolute position overflow scroll node is parented under the frame, not the dom-order parent.
     EXPECT_EQ(frameScroll(), absposOverflowScrollProperties->scroll()->parent());
     EXPECT_EQ(TransformationMatrix().translate(0, -41), absposOverflowScrollProperties->scroll()->scrollOffsetTranslation()->matrix());
     EXPECT_EQ(IntSize(9, 7), absposOverflowScrollProperties->scroll()->clip());
     EXPECT_EQ(IntSize(9, 4000), absposOverflowScrollProperties->scroll()->bounds());
 
     const ObjectPaintProperties* fixedOverflowScrollProperties = fixedOverflow->layoutObject()->objectPaintProperties();
     // The fixed position overflow scroll node is parented under the root, not the dom-order parent or frame's scroll.
-    EXPECT_EQ(rootScroll(), fixedOverflowScrollProperties->scroll()->parent());
+    EXPECT_TRUE(fixedOverflowScrollProperties->scroll()->parent()->isRoot());
     EXPECT_EQ(TransformationMatrix().translate(0, -43), fixedOverflowScrollProperties->scroll()->scrollOffsetTranslation()->matrix());
     EXPECT_EQ(IntSize(13, 11), fixedOverflowScrollProperties->scroll()->clip());
     EXPECT_EQ(IntSize(13, 4000), fixedOverflowScrollProperties->scroll()->bounds());
 }
 
 TEST_P(PaintPropertyTreeBuilderTest, NestedPositionedScrollProperties)
 {
     setBodyInnerHTML(
         "<style>"
         "  * {"
@@ skipping 28 matching lines @@
 
     Element* overflowA = document().getElementById("overflowA");
     overflowA->setScrollTop(37);
     Element* overflowB = document().getElementById("overflowB");
     overflowB->setScrollTop(41);
 
     document().view()->updateAllLifecyclePhases();
 
     const ObjectPaintProperties* overflowAScrollProperties = overflowA->layoutObject()->objectPaintProperties();
     // Because the frameView is does not scroll, overflowA's scroll should be under the root.
-    EXPECT_EQ(rootScroll(), overflowAScrollProperties->scroll()->parent());
+    EXPECT_TRUE(overflowAScrollProperties->scroll()->parent()->isRoot());
     EXPECT_EQ(TransformationMatrix().translate(0, -37), overflowAScrollProperties->scroll()->scrollOffsetTranslation()->matrix());
     EXPECT_EQ(IntSize(20, 20), overflowAScrollProperties->scroll()->clip());
     // 100 is the forceScroll element's height because the overflow child does not contribute to the height.
     EXPECT_EQ(IntSize(20, 100), overflowAScrollProperties->scroll()->bounds());
     EXPECT_TRUE(overflowAScrollProperties->scroll()->userScrollableHorizontal());
     EXPECT_TRUE(overflowAScrollProperties->scroll()->userScrollableVertical());
 
     const ObjectPaintProperties* overflowBScrollProperties = overflowB->layoutObject()->objectPaintProperties();
     // The overflow child's scroll node should be a child of the parent's (overflowA) scroll node.
     EXPECT_EQ(overflowAScrollProperties->scroll(), overflowBScrollProperties->scroll()->parent());
@@ skipping 135 matching lines @@
         "<div id='overflowA'>"
         "  <div id='overflowB' class='backgroundAttachmentFixed'>"
         "    <div class='forceScroll'></div>"
         "  </div>"
         "  <div class='forceScroll'></div>"
         "</div>"
         "<div class='forceScroll'></div>");
     Element* overflowA = document().getElementById("overflowA");
     Element* overflowB = document().getElementById("overflowB");
 
-    EXPECT_TRUE(rootScroll()->hasMainThreadScrollingReasons(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
     EXPECT_FALSE(overflowA->layoutObject()->objectPaintProperties()->scroll()->hasMainThreadScrollingReasons(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
     EXPECT_FALSE(overflowB->layoutObject()->objectPaintProperties()->scroll()->hasMainThreadScrollingReasons(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
+    EXPECT_TRUE(overflowB->layoutObject()->objectPaintProperties()->scroll()->parent()->hasMainThreadScrollingReasons(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
 
     // Removing a main thread scrolling reason should update the entire tree.
     overflowB->removeAttribute("class");
     document().view()->updateAllLifecyclePhases();
-    EXPECT_FALSE(rootScroll()->hasMainThreadScrollingReasons(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
     EXPECT_FALSE(overflowA->layoutObject()->objectPaintProperties()->scroll()->hasMainThreadScrollingReasons(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
     EXPECT_FALSE(overflowB->layoutObject()->objectPaintProperties()->scroll()->hasMainThreadScrollingReasons(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
+    EXPECT_FALSE(overflowB->layoutObject()->objectPaintProperties()->scroll()->parent()->hasMainThreadScrollingReasons(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
 }
 
 } // namespace blink