Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: PRESUBMIT.py

Issue 2359053002: Revert "Enable presubmit check for copyrighted material in added / modified code" (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 7d87d8850f6975eb4d1f36c0c152a686c773c9ee..3083e5455a90c559456b1d4a5eb31dd3eeb6381e 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1806,26 +1806,6 @@ def _CheckPydepsNeedsUpdating(input_api, output_api, checker_for_tests=None):
return results
-def _CheckForCopyrightedCode(input_api, output_api):
- """Verifies that newly added code doesn't contain copyrighted material
- and is properly licensed under the standard Chromium license.
-
- As there can be false positives, we maintain a whitelist file. This check
- also verifies that the whitelist file is up to date.
- """
- import sys
- original_sys_path = sys.path
- try:
- sys.path = sys.path + [input_api.os_path.join(
- input_api.PresubmitLocalPath(), 'tools')]
- from copyright_scanner import copyright_scanner
- finally:
- # Restore sys.path to what it was before.
- sys.path = original_sys_path
-
- return copyright_scanner.ScanAtPresubmit(input_api, output_api)
-
-
def _CheckSingletonInHeaders(input_api, output_api):
"""Checks to make sure no header files have |Singleton<|."""
def FileFilter(affected_file):
@@ -2004,7 +1984,6 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckNoDeprecatedJS(input_api, output_api))
results.extend(_CheckParseErrors(input_api, output_api))
results.extend(_CheckForIPCRules(input_api, output_api))
- results.extend(_CheckForCopyrightedCode(input_api, output_api))
results.extend(_CheckForWindowsLineEndings(input_api, output_api))
results.extend(_CheckSingletonInHeaders(input_api, output_api))
results.extend(_CheckNoDeprecatedCompiledResourcesGYP(input_api, output_api))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698