Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2359043002: cheets: switch arc wallpaper layout to CENTER_CROPPED. (Closed)

Created:
4 years, 3 months ago by Muyuan
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cheets: switch arc wallpaper layout to CENTER_CROPPED. Android wallpapers seem to be always center cropped that when wallpaper dimensions differ from the current workspace dimensions, it resizes to fill the screen while preserving aspect ratio and letting part of it to be cropped. This avoids bugs like b/31653316. BUG=642465 Test=Setting wallpaper functions as expected. Committed: https://crrev.com/d84782e1c6feb94dd33da0914c4b67f70e80e3cf Cr-Commit-Position: refs/heads/master@{#420441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/arc/arc_wallpaper_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Muyuan
4 years, 3 months ago (2016-09-22 00:50:06 UTC) #2
Luis Héctor Chávez
lgtm and this seems to be more aligned with what users expect.
4 years, 3 months ago (2016-09-22 17:19:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359043002/1
4 years, 3 months ago (2016-09-22 20:13:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 20:19:39 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d84782e1c6feb94dd33da0914c4b67f70e80e3cf Cr-Commit-Position: refs/heads/master@{#420441}
4 years, 3 months ago (2016-09-22 20:27:38 UTC) #8
Shuhei Takahashi
4 years, 3 months ago (2016-09-23 03:38:07 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698