Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2359033002: Fix Windows linker warning in components/policy/generated.lib (Closed)

Created:
4 years, 3 months ago by dcheng
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Windows linker warning in components/policy/generated.lib BUG=643470 Committed: https://crrev.com/2deedf078fe607d4f8d2823c3ca9ef8449558785 Cr-Commit-Position: refs/heads/master@{#420343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/policy/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
dcheng
Tested locally on a Windows component build.
4 years, 3 months ago (2016-09-22 00:33:36 UTC) #2
dcheng
Oops, tnagel is OOO. pastarmovj, mind taking a look?
4 years, 3 months ago (2016-09-22 09:06:24 UTC) #8
pastarmovj
lgtm
4 years, 3 months ago (2016-09-22 09:08:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359033002/1
4 years, 3 months ago (2016-09-22 15:03:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 15:09:08 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 15:11:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2deedf078fe607d4f8d2823c3ca9ef8449558785
Cr-Commit-Position: refs/heads/master@{#420343}

Powered by Google App Engine
This is Rietveld 408576698