Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 235903003: Remove FrameView::containsScrollableArea (Closed)

Created:
6 years, 8 months ago by abarth-chromium
Modified:
6 years, 8 months ago
Reviewers:
ojan
CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink, esprehn, ojan, Ian Vollick
Visibility:
Public.

Description

Remove FrameView::containsScrollableArea This function does a hash lookup and is needlessly indirect. Instead, we can just keep a bit on RenderLayerScrollableArea to remember whether we actually scroll. I was hoping this would make the tweetus demo from famo.us faster, but it didn't seem to have much of an effect. It's worth doing just for code clarity, however. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -29 lines) Patch
M Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 4 chunks +5 lines, -11 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 8 months ago (2014-04-11 21:59:36 UTC) #1
ojan
lgtm I agree that this is worth it for the code cleanup. I wonder if ...
6 years, 8 months ago (2014-04-11 23:25:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/235903003/1
6 years, 8 months ago (2014-04-11 23:25:56 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-12 00:33:48 UTC) #4
Message was sent while issue was closed.
Change committed as 171385

Powered by Google App Engine
This is Rietveld 408576698