Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2359023002: Add another test for initializing dispatchPropertyName that runs outside the browser (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add another test for initializing dispatchPropertyName that runs outside the browser R=johnniwinther@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3291ecfbc9c480fb3d59272ee6021123eaaedbaf

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
A tests/compiler/dart2js_native/dispatch_property_initialization_test.dart View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sra1
4 years, 3 months ago (2016-09-21 22:03:50 UTC) #1
Johnni Winther
lgtm https://codereview.chromium.org/2359023002/diff/1/tests/compiler/dart2js_native/dispatch_property_initialization_test.dart File tests/compiler/dart2js_native/dispatch_property_initialization_test.dart (right): https://codereview.chromium.org/2359023002/diff/1/tests/compiler/dart2js_native/dispatch_property_initialization_test.dart#newcode30 tests/compiler/dart2js_native/dispatch_property_initialization_test.dart:30: // `null` instead oif teh secrst string or ...
4 years, 3 months ago (2016-09-22 08:15:55 UTC) #2
sra1
https://codereview.chromium.org/2359023002/diff/1/tests/compiler/dart2js_native/dispatch_property_initialization_test.dart File tests/compiler/dart2js_native/dispatch_property_initialization_test.dart (right): https://codereview.chromium.org/2359023002/diff/1/tests/compiler/dart2js_native/dispatch_property_initialization_test.dart#newcode30 tests/compiler/dart2js_native/dispatch_property_initialization_test.dart:30: // `null` instead oif teh secrst string or Symbol. ...
4 years, 3 months ago (2016-09-22 16:43:14 UTC) #3
sra1
4 years, 3 months ago (2016-09-22 16:45:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3291ecfbc9c480fb3d59272ee6021123eaaedbaf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698