components/arc/arc_features.cc - Issue 2359003004: Disable ACTION_BOOT_COMPLETED event for 3rd party apps.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/arc_features.cc

Issue 2359003004: Disable ACTION_BOOT_COMPLETED event for 3rd party apps. (Closed)

Patch Set: Replace flags with feature list. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #include "components/arc/arc_features.h"

	5

	6 namespace features {

	7

	8 #if defined(OS_CHROMEOS)

	9 // Disable ACTION_BOOT_COMPLETD broadcast for 3rd party applications on ARC.

	10 const base::Feature kDisableArcBootCompletedBroadcast{

	11 "DisableArcBootCompletedBroadcast", base::FEATURE_DISABLED_BY_DEFAULT};
	Alexei Svitkine (slow) 2016/09/30 21:34:04 Instead of making the feature called kDisable* and Instead of making the feature called kDisable* and making it disabled by default (double negative), make the feature kArcBootCompletedBroadcast and make it enabled by default. xzhou 2016/10/01 00:37:42 I changed the variable name as well as the descrip Show quoted text On 2016/09/30 21:34:04, Alexei Svitkine (slow) wrote: > Instead of making the feature called kDisable* and making it disabled by default > (double negative), make the feature kArcBootCompletedBroadcast and make it > enabled by default. I changed the variable name as well as the description. But the variable name in arc_bridge_bootstrap.cc is not changed because the IPC is already defined. Thanks.
	12 #endif // defined(OS_CHROMEOS)

	13

	14 }

OLD	NEW