components/arc/arc_features.h - Issue 2359003004: Disable ACTION_BOOT_COMPLETED event for 3rd party apps.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/arc_features.h

Issue 2359003004: Disable ACTION_BOOT_COMPLETED event for 3rd party apps. (Closed)

Patch Set: Revise flag string. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file defines the public base::FeatureList features for ARC.

	6

	7 #ifndef CHROMEOS_ARC_FEATURES_H_
	Daniel Erat 2016/10/03 22:39:28 this is the wrong header guard for this file's pat this is the wrong header guard for this file's path. i thought we had a presubmit about this. CHROMEOS_COMPONENTS_ARC_ARC_FEATURES_H_ xzhou 2016/10/03 23:29:31 Done. Show quoted text On 2016/10/03 22:39:28, Daniel Erat wrote: > this is the wrong header guard for this file's path. i thought we had a > presubmit about this. > > CHROMEOS_COMPONENTS_ARC_ARC_FEATURES_H_ Done.
	8 #define CHROMEOS_ARC_FEATURES_H_

	9

	10 #include "base/feature_list.h"

	11

	12 namespace arc {

	13

	14 #if defined(OS_CHROMEOS)
	Daniel Erat 2016/10/03 22:39:28 this ifdef doesn't make sense. this file shouldn't this ifdef doesn't make sense. this file shouldn't be built for non-chrome-os platforms, and there are no similar ifdefs in components/arc/.
	15 extern const base::Feature kArcBootCompletedBroadcast;
	Daniel Erat 2016/10/03 22:39:28 please rename this to kBootCompletedBroadcastFeatu please rename this to kBootCompletedBroadcastFeature -- the "Arc" at the beginning seems redundant since it's already in the "arc" namespace, and it should have "Feature" at the end to make its type more obvious when it's referenced from some other file. xzhou 2016/10/03 23:29:31 Done. Show quoted text On 2016/10/03 22:39:28, Daniel Erat wrote: > please rename this to kBootCompletedBroadcastFeature -- the "Arc" at the > beginning seems redundant since it's already in the "arc" namespace, and it > should have "Feature" at the end to make its type more obvious when it's > referenced from some other file. Done.
	16 #endif // defined(OS_CHROMEOS)

	17

	18 } // namespace arc

	19

	20 #endif // CHROMEOS_ARC_FEATURES_H_

OLD	NEW

« components/arc/arc_bridge_bootstrap.cc ('K') | « components/arc/arc_bridge_bootstrap.cc ('k') | components/arc/arc_features.cc » ('j') | components/arc/arc_features.cc » ('J')