Convert tests that parse a BasicConstraints value to instead

Convert tests that parse a BasicConstraints value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
Committed: https://crrev.com/07f7dafbfff3d483be66ddd85e1ed516f162e744
Cr-Commit-Position: refs/heads/master@{#420524}

[eroman, 2016-09-22 00:17:51]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 00:18:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-22 01:03:50]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 01:04:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-22 01:05:33]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[eroman, 2016-09-22 01:05:33]

(Per discussion over email)

[commit-bot: I haz the power, 2016-09-22 02:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 02:16:01]

Dry run: This issue passed the CQ dry run.

[mattm, 2016-09-22 02:48:20]

https://codereview.chromium.org/2359003003/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate_unittest.cc (right):

https://codereview.chromium.org/2359003003/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate_unittest.cc:662:
ASSERT_FALSE(ParseCertificateFromFile("basic_constraints_pathlen_256.pem"));
Is there a TODO for adding error logging to ParseBasicConstraints?

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
File net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py (right):

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py:12: <asci-der
values in here>
ascii

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py:48: (name,
name), re.DOTALL)
Shouldn't matter given the types of names being used, but re.escape(name) would
be safer.

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py:75: if
num_matches  == 0:
extra space

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
File net/data/parse_certificate_unittest/v3_certificate_template.txt (right):

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
net/data/parse_certificate_unittest/v3_certificate_template.txt:13: #-----BEGIN
VERSION-----
SERIAL_NUMBER?

[eroman, 2016-09-22 06:12:18]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 06:12:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-22 06:12:51]

Description was changed from

==========
Convert the tests that parse a BasicConstraints value to instead
parsing an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

to

==========
Convert tests that parse a BasicConstraints value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

[eroman, 2016-09-22 06:13:14]

https://codereview.chromium.org/2359003003/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate_unittest.cc (right):

https://codereview.chromium.org/2359003003/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate_unittest.cc:662:
ASSERT_FALSE(ParseCertificateFromFile("basic_constraints_pathlen_256.pem"));
On 2016/09/22 02:48:19, mattm wrote:
> Is there a TODO for adding error logging to ParseBasicConstraints?

I have added a TODO to ParseCertificateFromFile().


(That will ensure that every parsing failure being tested has error
information).
I will keep chipping away at these in follow-up.

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
File net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py (right):

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py:12: <asci-der
values in here>
On 2016/09/22 02:48:19, mattm wrote:
> ascii

Done.

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py:48: (name,
name), re.DOTALL)
On 2016/09/22 02:48:19, mattm wrote:
> Shouldn't matter given the types of names being used, but re.escape(name)
would
> be safer.

Done.

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py:75: if
num_matches  == 0:
On 2016/09/22 02:48:20, mattm wrote:
> extra space

Done.

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
File net/data/parse_certificate_unittest/v3_certificate_template.txt (right):

https://codereview.chromium.org/2359003003/diff/20001/net/data/parse_certific...
net/data/parse_certificate_unittest/v3_certificate_template.txt:13: #-----BEGIN
VERSION-----
On 2016/09/22 02:48:20, mattm wrote:
> SERIAL_NUMBER?

Done -- in fact I have removed all of the unused section names (will propose
them separately when adding the tests which use them).

[commit-bot: I haz the power, 2016-09-22 07:19:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 07:19:14]

Dry run: This issue passed the CQ dry run.

[mattm, 2016-09-22 22:30:57]

lgtm

https://codereview.chromium.org/2359003003/diff/40001/net/cert/internal/parse...
File net/cert/internal/parse_certificate_unittest.cc (right):

https://codereview.chromium.org/2359003003/diff/40001/net/cert/internal/parse...
net/cert/internal/parse_certificate_unittest.cc:105: // TODO(crbug.com/634443):
Every parse failue being tested should emit error
failure

[eroman, 2016-09-22 22:45:16]

https://codereview.chromium.org/2359003003/diff/40001/net/cert/internal/parse...
File net/cert/internal/parse_certificate_unittest.cc (right):

https://codereview.chromium.org/2359003003/diff/40001/net/cert/internal/parse...
net/cert/internal/parse_certificate_unittest.cc:105: // TODO(crbug.com/634443):
Every parse failue being tested should emit error
On 2016/09/22 22:30:57, mattm wrote:
> failure

Done.

[eroman, 2016-09-22 22:45:21]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-09-22 22:45:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2359003003/#ps60001
(title: "fix comment")

[commit-bot: I haz the power, 2016-09-22 22:46:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 01:08:05]

Description was changed from

==========
Convert tests that parse a BasicConstraints value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

to

==========
Convert tests that parse a BasicConstraints value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

[commit-bot: I haz the power, 2016-09-23 01:08:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-23 01:10:44]

Description was changed from

==========
Convert tests that parse a BasicConstraints value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

to

==========
Convert tests that parse a BasicConstraints value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443

Committed: https://crrev.com/07f7dafbfff3d483be66ddd85e1ed516f162e744
Cr-Commit-Position: refs/heads/master@{#420524}
==========

[commit-bot: I haz the power, 2016-09-23 01:10:45]

Patchset 4 (id:??) landed as
https://crrev.com/07f7dafbfff3d483be66ddd85e1ed516f162e744
Cr-Commit-Position: refs/heads/master@{#420524}