third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp - Issue 2358993003: Service worker creation from <link> leads to nullptr dereference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

Issue 2358993003: Service worker creation from <link> leads to nullptr dereference (Closed)

Patch Set: Formatting Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/sandbox-iframe-register-link-element.html ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

index b47a8652bab7238b03bf66639f634b1ad922c7c0..19c24001af095b98347f753987327e33cb245f2c 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

@@ -60,6 +60,8 @@ ServiceWorkerContainer* NavigatorServiceWorker::serviceWorker(LocalFrame* frame,

if (frame && !frame->securityContext()->getSecurityOrigin()->canAccessServiceWorkers()) {

if (frame->securityContext()->isSandboxed(SandboxOrigin))

exceptionState.throwSecurityError("Service worker is disabled because the context is sandboxed and lacks the 'allow-same-origin' flag.");

+ else if (frame->securityContext()->getSecurityOrigin()->hasSuborigin())

+ exceptionState.throwSecurityError("Service worker is disabled because the context is in a suborigin.");

else

exceptionState.throwSecurityError("Access to service workers is denied in this document origin.");

return nullptr;