third_party/WebKit/LayoutTests/http/tests/serviceworker/sandbox-iframe-register-link-element.html - Issue 2358993003: Service worker creation from <link> leads to nullptr dereference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/sandbox-iframe-register-link-element.html

Issue 2358993003: Service worker creation from <link> leads to nullptr dereference (Closed)

Patch Set: Nits from falken@ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/iframe-register-link-element.html ('k') | third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/sandbox-iframe-register-link-element.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/sandbox-iframe-register-link-element.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/sandbox-iframe-register-link-element.html

new file mode 100644

index 0000000000000000000000000000000000000000..27e3b42056353de4aa29e3cdfbba3676b7800f83

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/sandbox-iframe-register-link-element.html

@@ -0,0 +1,23 @@

+<!DOCTYPE html>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<script src="resources/test-helpers.js"></script>

+<script src="resources/registration-tests.js"></script>

+<body>

+<script>

+async_test(function(t) {

+ window.addEventListener('message', function(e) {

+ if (e.data == 'error') {

+ t.step(function() {

+ t.done();

+ });

+ } else {

+ t.step(function() {

+ assert_unreached('iframe successfully loaded service worker');

+ });

+ }

+ });

falken 2016/09/24 15:04:29 almost! lines 9-19 should be indented an additiona

jww 2016/09/24 16:25:07 Dang! Thanks :-)

+ }, 'Sandboxed iframe should not be able to register service worker with link rel');

+</script>

+<iframe src="resources/iframe-register-link-element.html" sandbox="allow-scripts"></iframe>

+</body>