third_party/WebKit/LayoutTests/http/tests/serviceworker/sandbox-iframe-register-link-element.html - Issue 2358993003: Service worker creation from <link> leads to nullptr dereference

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/sandbox-iframe-register-link-element.html

Issue 2358993003: Service worker creation from <link> leads to nullptr dereference (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/iframe-register-link-element.html ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/iframe-register-link-element.html ('k') | third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script src="resources/test-helpers.js"></script>

	5 <script src="resources/registration-tests.js"></script>

	6 <body>

	7 <script>

	8 var t = async_test('Sandboxed iframe should not be able to register service worker with link rel');

	9 window.addEventListener('message', function(e) {

	10 if (e.data == 'error') {

	11 t.step(function() {

	12 t.done();

	13 });

	14 } else {

	15 t.step(function() {

	16 assert_unreached('iframe successfully loaded service worker');

	17 });

	18 }

	19 });
	falken 2016/09/23 01:22:33 Since this is serviceworker/ it should use the som Since this is serviceworker/ it should use the somewhat unorthodox style described here: http://www.chromium.org/blink/serviceworker/testing Namely: - Use async_test(function(t) { ... }, 'Sandboxed...'); - Indent function arguments like this: window.addEventListener('message', function(e) { console.log('hi'); }); jww 2016/09/23 04:34:47 Yikes! I had no idea. I tried to update to match t Show quoted text On 2016/09/23 01:22:33, falken wrote: > Since this is serviceworker/ it should use the somewhat unorthodox style > described here: > http://www.chromium.org/blink/serviceworker/testing > > Namely: > - Use async_test(function(t) { ... }, 'Sandboxed...'); > - Indent function arguments like this: > > window.addEventListener('message', function(e) { > console.log('hi'); > }); Yikes! I had no idea. I tried to update to match the style, but you'll probably want to double check...
	20 </script>

	21 <iframe src="resources/iframe-register-link-element.html" sandbox="allow-scr ipts"></iframe>

	22 </body>

OLD	NEW