third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/iframe-register-link-element.html - Issue 2358993003: Service worker creation from <link> leads to nullptr dereference

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/iframe-register-link-element.html

Issue 2358993003: Service worker creation from <link> leads to nullptr dereference (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <script>

	2 var link = document.createElement('link');

	3 link.setAttribute('rel', 'serviceworker');

	4 link.setAttribute('href', 'fetch-event-network-error-worker.js');
	falken 2016/09/23 01:22:33 similarly, I'd use empty-worker.js here. similarly, I'd use empty-worker.js here. jww 2016/09/23 04:34:47 Done. Show quoted text On 2016/09/23 01:22:33, falken wrote: > similarly, I'd use empty-worker.js here. Done.
	5 link.onload = function() {

	6 top.postMessage('loaded', '*');

	7 }

	8 link.onerror = function(e) {

	9 top.postMessage('error', '*');

	10 }

	11 document.getElementsByTagName('head')[0].appendChild(link);

	12 </script>

OLD	NEW