Add repro for crash when opening window with --allow-insecure-localhost.

chrome/browser/ssl/ssl_browser_tests.cc

Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index c5a237cd799edd5a717ca093b45dc4ae631f6d3f..9ee95281c107a738998d3fbae6d63858c8e56c30 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -3245,6 +3245,26 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, PushStateSSLState) {
   CheckAuthenticatedState(tab, AuthState::NONE);
 }
 
+class SSLUITestAlllowInsecureHost : public SSLUITest {

[estark, 2016/09/22 20:34:03]

There's already SSLUITestIgnoreLocalhostCertErrors if you want to use that
instead.

[jam, 2016/09/22 22:25:16]

Done

+ public:
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitch(switches::kAllowInsecureLocalhost);
+    SSLUITest::SetUpCommandLine(command_line);
+  }
+};
+
+// Regression test for http://crbug.com/635833 (crash when a window with no
+// NavigationEntry commits).
+IN_PROC_BROWSER_TEST_F(SSLUITestAlllowInsecureHost,
+                       NoCrashOnLoadWithNoNavigationEntry) {
+  ASSERT_TRUE(embedded_test_server()->Start());
+
+  ui_test_utils::NavigateToURL(
+      browser(), embedded_test_server()->GetURL("/ssl/google.html"));
+  WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
+  ASSERT_TRUE(content::ExecuteScript(tab, "window.open()"));
+}
+
 // TODO(jcampan): more tests to do below.
 
 // Visit a page over https that contains a frame with a redirect.