Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: components/ntp_snippets/user_classifier.h

Issue 2358983003: Making UserClassifier configurable by variation parameters (Closed)
Patch Set: Marc's comments #2 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/user_classifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/user_classifier.h
diff --git a/components/ntp_snippets/user_classifier.h b/components/ntp_snippets/user_classifier.h
index 9ce1c4a3463db9e1d8ac51e0db9cfc8af86745f9..4f8c9848d62d30e16e7ab678d7e56e1114389e7b 100644
--- a/components/ntp_snippets/user_classifier.h
+++ b/components/ntp_snippets/user_classifier.h
@@ -17,7 +17,7 @@ namespace ntp_snippets {
// Collects data about user usage patterns of content suggestions, computes
// long-term user metrics locally using pref, and reports the metrics to UMA.
-// Based on these lon-term user metrics, it classifies the user in a UserClass.
+// Based on these long-term user metrics, it classifies the user in a UserClass.
class UserClassifier {
public:
// Enumeration listing user classes
@@ -91,7 +91,15 @@ class UserClassifier {
void ClearMetricValue(Metric metric);
PrefService* pref_service_;
+
+ // Params of the metric.
const double discount_rate_per_hour_;
+ const double min_hours_;
+ const double max_hours_;
+
+ // Params of the classification.
+ const double active_consumer_scrolls_at_least_once_per_hours_;
+ const double rare_user_opens_ntp_at_most_once_per_hours_;
DISALLOW_COPY_AND_ASSIGN(UserClassifier);
};
« no previous file with comments | « no previous file | components/ntp_snippets/user_classifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698