Making UserClassifier configurable by variation parameters

components/ntp_snippets/user_classifier.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/user_classifier.h"
 
 #include <float.h>
 
 #include <algorithm>
 #include <string>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"
+#include "components/ntp_snippets/features.h"
 #include "components/ntp_snippets/pref_names.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
+#include "components/variations/variations_associated_data.h"
 
 namespace ntp_snippets {
 
 namespace {
 
-// TODO(jkrcal): Make all of this configurable via variations_service.
-
 // The discount factor for computing the discounted-average metrics. Must be
 // strictly larger than 0 and strictly smaller than 1!
 const double kDiscountFactorPerDay = 0.25;
+const char kDiscountFactorPerDayParam[] =
+    "user_classifier_discount_factor_per_day";
 
 // Never consider any larger interval than this (so that extreme situations such
 // as losing your phone or going for a long offline vacation do not skew the
 // average too much).
 const double kMaxHours = 7 * 24;
+const char kMaxHoursParam[] =
+    "user_classifier_max_hours";

[Marc Treib, 2016/09/22 12:29:05]

fits on the previous line

[jkrcal, 2016/09/22 13:26:15]

Done.

 
 // Ignore events within |kMinHours| hours since the last event (|kMinHours| is
 // the length of the browsing session where subsequent events of the same type
 // do not count again).
 const double kMinHours = 0.5;
+const char kMinHoursParam[] =
+    "user_classifier_min_hours";

[Marc Treib, 2016/09/22 12:29:05]

here too

[jkrcal, 2016/09/22 13:26:15]

Done.

 
 // Classification constants.
-const double kFrequentUserScrollsAtLeastOncePerHours = 24;
-const double kOccasionalUserOpensNTPAtMostOncePerHours = 72;
+const double kActiveConsumerScrollsAtLeastOncePerHours = 24;
+const char kActiveConsumerScrollsAtLeastOncePerHoursParam[] =
+    "user_classifier_active_consumer_scrolls_at_least_once_per_hours";
 
+const double kActiveConsumerOpensNTPAtLeastOncePerHours = 24;
+const char kActiveConsumerOpensNTPAtLeastOncePerHoursParam[] =
+    "user_classifier_active_consumer_opens_ntp_at_least_once_per_hours";
+
+const double kRareUserOpensNTPAtMostOncePerHours = 72;
+const char kRareUserOpensNTPAtMostOncePerHoursParam[] =
+    "user_classifier_rare_user_opens_ntp_at_most_once_per_hours";
+
+// Histograms for logging the estimated average hours to next event.
 const char kHistogramAverageHoursToOpenNTP[] =
     "NewTabPage.UserClassifier.AverageHoursToOpenNTP";
 const char kHistogramAverageHoursToShowSuggestions[] =
     "NewTabPage.UserClassifier.AverageHoursToShowSuggestions";
 const char kHistogramAverageHoursToUseSuggestions[] =
     "NewTabPage.UserClassifier.AverageHoursToUseSuggestions";
 
 // The enum used for iteration.
 const UserClassifier::Metric kMetrics[] = {
     UserClassifier::Metric::NTP_OPENED,
     UserClassifier::Metric::SUGGESTIONS_SHOWN,
     UserClassifier::Metric::SUGGESTIONS_USED};
 
 // The summary of the prefs.
 const char* kMetricKeys[] = {
     prefs::kUserClassifierAverageNTPOpenedPerHour,
     prefs::kUserClassifierAverageSuggestionsShownPerHour,
     prefs::kUserClassifierAverageSuggestionsUsedPerHour};
 const char* kLastTimeKeys[] = {prefs::kUserClassifierLastTimeToOpenNTP,
                                prefs::kUserClassifierLastTimeToShowSuggestions,
                                prefs::kUserClassifierLastTimeToUseSuggestions};
 
 // Default lengths of the intervals for new users for the metrics.
 const double kDefaults[] = {24, 36, 48};
+const char* kDefaultParams[] = {

[Marc Treib, 2016/09/22 12:29:05]

I think these could use a bit more descriptive names.
kInitialHoursBetweenEvents[Params] or something?

[jkrcal, 2016/09/22 13:26:14]

Done.

+    "user_classifier_default_interval_ntp_opened",
+    "user_classifier_default_interval_suggestions_shown",
+    "user_classifier_default_interval_suggestions_used"};
 
 static_assert(arraysize(kMetrics) ==
                       static_cast<int>(UserClassifier::Metric::COUNT) &&
                   arraysize(kMetricKeys) ==
                       static_cast<int>(UserClassifier::Metric::COUNT) &&
                   arraysize(kLastTimeKeys) ==
                       static_cast<int>(UserClassifier::Metric::COUNT) &&
                   arraysize(kDefaults) ==
                       static_cast<int>(UserClassifier::Metric::COUNT),

[Marc Treib, 2016/09/22 12:29:05]

Add kDefaultParams?

[jkrcal, 2016/09/22 13:26:15]

Done.

               "Fill in info for all metrics.");
 
+double GetParamValue(const char* param_name, double default_value) {
+  std::string param_value_str = variations::GetVariationParamValueByFeature(
+      kArticleSuggestionsFeature, param_name);
+  double param_value = 0;
+  if (!base::StringToDouble(param_value_str, &param_value)) {
+    LOG_IF(WARNING, !param_value_str.empty())
+        << "Invalid variation parameter for " << param_name;
+    return default_value;
+  }
+  return param_value;
+}
+
 // Computes the discount rate.
 double GetDiscountRatePerHour() {
+  double discount_factor_per_day =
+      GetParamValue(kDiscountFactorPerDayParam, kDiscountFactorPerDay);
   // Compute discount_rate_per_hour such that
-  //   kDiscountFactorPerDay = 1 - e^{-discount_rate_per_hour * 24}.
-  return std::log(1.0 / (1.0 - kDiscountFactorPerDay)) / 24.0;
+  //   discount_factor_per_day = 1 - e^{-discount_rate_per_hour * 24}.
+  return std::log(1.0 / (1.0 - discount_factor_per_day)) / 24.0;
+}
+
+double GetDefaultEstimate(UserClassifier::Metric metric) {

[Marc Treib, 2016/09/22 12:29:05]

GetDefaultEstimateHoursBetweenEvents or GetInitialEstimateHoursBetweenEvents?

[jkrcal, 2016/09/22 13:26:15]

Done. GetInitialHoursBetweenEvents to match the const variables above. Actually
there is nothing estimated in the default value (they are just gonna be
interpreted as estimates later).

+  return GetParamValue(kDefaultParams[static_cast<int>(metric)],
+                       kDefaults[static_cast<int>(metric)]);
+}
+
+double GetMinHours() {
+  return GetParamValue(kMinHoursParam, kMinHours);
+}
+
+double GetMaxHours() {
+  return GetParamValue(kMaxHoursParam, kMaxHours);
 }
 
 // Returns the new value of the metric using its |old_value|, assuming
 // |hours_since_last_time| hours have passed since it was last discounted.
 double DiscountMetric(double old_value,
                       double hours_since_last_time,
                       double discount_rate_per_hour) {
   // Compute the new discounted average according to the formula
   //   avg_events := e^{-discount_rate_per_hour * hours_since} * avg_events
   return std::exp(-discount_rate_per_hour * hours_since_last_time) * old_value;
 }
 
 // Compute the number of hours between two events for the given metric value
 // assuming the events were equally distributed.
 double GetEstimateHoursBetweenEvents(double metric_value,
-                                     double discount_rate_per_hour) {
+                                     double discount_rate_per_hour,
+                                     double min_hours,
+                                     double max_hours) {
   // The computation below is well-defined only for |metric_value| > 1 (log of
   // negative value or division by zero). When |metric_value| -> 1, the estimate
-  // below -> infinity, so kMaxHours is a natural result, here.
+  // below -> infinity, so max_hours is a natural result, here.
   if (metric_value <= 1)
-    return kMaxHours;
+    return max_hours;
 
   // This is the estimate with the assumption that last event happened right
   // now and the system is in the steady-state. Solve estimate_hours in the
   // steady-state equation:
   //   metric_value = 1 + e^{-discount_rate * estimate_hours} * metric_value,
   // i.e.
   //   -discount_rate * estimate_hours = log((metric_value - 1) / metric_value),
   //   discount_rate * estimate_hours = log(metric_value / (metric_value - 1)),
   //   estimate_hours = log(metric_value / (metric_value - 1)) / discount_rate.
   double estimate_hours =
       std::log(metric_value / (metric_value - 1)) / discount_rate_per_hour;
-  return std::max(kMinHours, std::min(kMaxHours, estimate_hours));
+  return std::max(min_hours, std::min(max_hours, estimate_hours));
 }
 
 // The inverse of GetEstimateHoursBetweenEvents().
 double GetMetricValueForEstimateHoursBetweenEvents(
     double estimate_hours,
-    double discount_rate_per_hour) {
-  // Keep the input value within [kMinHours, kMaxHours].
-  estimate_hours = std::max(kMinHours, std::min(kMaxHours, estimate_hours));
-
+    double discount_rate_per_hour,
+    double min_hours,
+    double max_hours) {
+  // Keep the input value within [min_hours, max_hours].
+  estimate_hours = std::max(min_hours, std::min(max_hours, estimate_hours));
   // Return |metric_value| such that GetEstimateHoursBetweenEvents for
   // |metric_value| returns |estimate_hours|. Thus, solve |metric_value| in
   //   metric_value = 1 + e^{-discount_rate * estimate_hours} * metric_value,
   // i.e.
   //   metric_value * (1 - e^{-discount_rate * estimate_hours}) = 1,
   //   metric_value = 1 / (1 - e^{-discount_rate * estimate_hours}).
   return 1.0 / (1.0 - std::exp(-discount_rate_per_hour * estimate_hours));
 }
 
 }  // namespace
 
 UserClassifier::UserClassifier(PrefService* pref_service)
     : pref_service_(pref_service),
-      discount_rate_per_hour_(GetDiscountRatePerHour()) {
+      discount_rate_per_hour_(GetDiscountRatePerHour()),
+      min_hours_(GetMinHours()),
+      max_hours_(GetMaxHours()),
+      active_consumer_scrolls_at_least_once_per_hours_(
+          GetParamValue(kActiveConsumerScrollsAtLeastOncePerHoursParam,
+                        kActiveConsumerScrollsAtLeastOncePerHours)),
+      active_consumer_opens_ntp_at_least_once_per_hours_(
+          GetParamValue(kActiveConsumerOpensNTPAtLeastOncePerHoursParam,
+                        kActiveConsumerOpensNTPAtLeastOncePerHours)),
+      rare_user_opens_ntp_at_most_once_per_hours_(
+          GetParamValue(kRareUserOpensNTPAtMostOncePerHoursParam,
+                        kRareUserOpensNTPAtMostOncePerHours)) {
   // The pref_service_ can be null in tests.
   if (!pref_service_)
     return;
 
+  // TODO(jkrcal): Store the current discount rate per hour into prefs. If it
+  // differs from the previous value, rescale the metric values so that the
+  // expectation does not change abruptly!
+
   // Initialize the prefs storing the last time: the counter has just started!
   for (const Metric metric : kMetrics) {
     if (!HasLastTime(metric))
       SetLastTimeToNow(metric);
   }
 }
 
 UserClassifier::~UserClassifier() {}
 
 // static
 void UserClassifier::RegisterProfilePrefs(PrefRegistrySimple* registry) {
+  double discount_rate = GetDiscountRatePerHour();
+  double min_hours = GetMinHours();
+  double max_hours = GetMaxHours();
+
   for (Metric metric : kMetrics) {
     double default_metric_value = GetMetricValueForEstimateHoursBetweenEvents(
-        kDefaults[static_cast<int>(metric)], GetDiscountRatePerHour());
+        GetDefaultEstimate(metric), discount_rate, min_hours, max_hours);
     registry->RegisterDoublePref(kMetricKeys[static_cast<int>(metric)],
                                  default_metric_value);
     registry->RegisterInt64Pref(kLastTimeKeys[static_cast<int>(metric)], 0);
   }
 }
 
 void UserClassifier::OnEvent(Metric metric) {
   DCHECK_NE(metric, Metric::COUNT);
   double metric_value = UpdateMetricOnEvent(metric);
 
-  double avg =
-      GetEstimateHoursBetweenEvents(metric_value, discount_rate_per_hour_);
+  double avg = GetEstimateHoursBetweenEvents(
+      metric_value, discount_rate_per_hour_, min_hours_, max_hours_);
   switch (metric) {
     case Metric::NTP_OPENED:
       UMA_HISTOGRAM_CUSTOM_COUNTS(kHistogramAverageHoursToOpenNTP, avg, 1,
                                   kMaxHours, 50);

[Marc Treib, 2016/09/22 12:29:05]

Hm, so the histograms still use kMaxHours rather than max_hours. That's
necessary, but maybe worth a comment?

[jkrcal, 2016/09/22 13:26:14]

Oh, I missed this, thanks! Comments added.

       break;
     case Metric::SUGGESTIONS_SHOWN:
       UMA_HISTOGRAM_CUSTOM_COUNTS(kHistogramAverageHoursToShowSuggestions, avg,
                                   1, kMaxHours, 50);
       break;
     case Metric::SUGGESTIONS_USED:
       UMA_HISTOGRAM_CUSTOM_COUNTS(kHistogramAverageHoursToUseSuggestions, avg,
                                   1, kMaxHours, 50);
       break;
     case Metric::COUNT:
       NOTREACHED();
       break;
   }
 }
 
 double UserClassifier::GetEstimatedAvgTime(Metric metric) const {
   DCHECK_NE(metric, Metric::COUNT);
   double metric_value = GetUpToDateMetricValue(metric);
-  return GetEstimateHoursBetweenEvents(metric_value, discount_rate_per_hour_);
+  return GetEstimateHoursBetweenEvents(metric_value, discount_rate_per_hour_,
+                                       min_hours_, max_hours_);
 }
 
 UserClassifier::UserClass UserClassifier::GetUserClass() const {
-  if (GetEstimatedAvgTime(Metric::NTP_OPENED) >=
-      kOccasionalUserOpensNTPAtMostOncePerHours) {
+  double avg_time_to_ntp = GetEstimatedAvgTime(Metric::NTP_OPENED);
+
+  if (avg_time_to_ntp >= rare_user_opens_ntp_at_most_once_per_hours_) {
     return UserClass::RARE_NTP_USER;
   }
 
-  if (GetEstimatedAvgTime(Metric::SUGGESTIONS_SHOWN) <=
-      kFrequentUserScrollsAtLeastOncePerHours) {
+  double avg_time_to_scroll = GetEstimatedAvgTime(Metric::SUGGESTIONS_SHOWN);
+
+  if (avg_time_to_ntp <= active_consumer_opens_ntp_at_least_once_per_hours_ &&
+      avg_time_to_scroll <= active_consumer_scrolls_at_least_once_per_hours_) {
     return UserClass::ACTIVE_SUGGESTIONS_CONSUMER;
   }
 
   return UserClass::ACTIVE_NTP_USER;
 }
 
 std::string UserClassifier::GetUserClassDescriptionForDebugging() const {
   switch (GetUserClass()) {
     case UserClass::RARE_NTP_USER:
       return "Rare user of the NTP";
@@ skipping 16 matching lines @@
     SetLastTimeToNow(metric);
   }
 }
 
 double UserClassifier::UpdateMetricOnEvent(Metric metric) {
   // The pref_service_ can be null in tests.
   if (!pref_service_)
     return 0;
 
   double hours_since_last_time =
-      std::min(kMaxHours, GetHoursSinceLastTime(metric));
+      std::min(max_hours_, GetHoursSinceLastTime(metric));
   // Ignore events within the same "browsing session".
-  if (hours_since_last_time < kMinHours)
+  if (hours_since_last_time < min_hours_)
     return GetUpToDateMetricValue(metric);
 
   SetLastTimeToNow(metric);
 
   double metric_value = GetMetricValue(metric);
   // Add 1 to the discounted metric as the event has happened right now.
   double new_metric_value =
       1 + DiscountMetric(metric_value, hours_since_last_time,
                           discount_rate_per_hour_);
   SetMetricValue(metric, new_metric_value);
   return new_metric_value;
 }
 
 double UserClassifier::GetUpToDateMetricValue(Metric metric) const {
   // The pref_service_ can be null in tests.
   if (!pref_service_)
     return 0;
 
   double hours_since_last_time =
-      std::min(kMaxHours, GetHoursSinceLastTime(metric));
+      std::min(max_hours_, GetHoursSinceLastTime(metric));
 
   double metric_value = GetMetricValue(metric);
   return DiscountMetric(metric_value, hours_since_last_time,
                         discount_rate_per_hour_);
 }
 
 double UserClassifier::GetHoursSinceLastTime(Metric metric) const {
   if (!HasLastTime(metric))
     return 0;
 
@@ skipping 18 matching lines @@
 
 void UserClassifier::SetMetricValue(Metric metric, double metric_value) {
   pref_service_->SetDouble(kMetricKeys[static_cast<int>(metric)], metric_value);
 }
 
 void UserClassifier::ClearMetricValue(Metric metric) {
   pref_service_->ClearPref(kMetricKeys[static_cast<int>(metric)]);
 }
 
 }  // namespace ntp_snippets