Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 235893017: Break a single histogram into two (Closed)

Created:
6 years, 8 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Break a single histogram into two histograms This histogram records a networking result that if positive indicates a byte count, and if negative indicates an error code. Since histograms can't handle negative values, this splits that up into two: one for the byte count, and one that will use an existing enum for the network error code. This was based off of a suggestion in codereview.chromium.org/236023005 BUG=360909 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264323

Patch Set 1 #

Patch Set 2 : fixed missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M extensions/browser/extension_protocols.cc View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
asargent_no_longer_on_chrome
6 years, 8 months ago (2014-04-15 23:50:37 UTC) #1
Alexei Svitkine (slow)
LGTM
6 years, 8 months ago (2014-04-16 14:21:49 UTC) #2
asargent_no_longer_on_chrome
The CQ bit was checked by asargent@chromium.org
6 years, 8 months ago (2014-04-16 14:41:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/235893017/20001
6 years, 8 months ago (2014-04-16 14:41:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 15:29:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-16 15:29:28 UTC) #6
asargent_no_longer_on_chrome
The CQ bit was checked by asargent@chromium.org
6 years, 8 months ago (2014-04-16 18:03:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/235893017/40001
6 years, 8 months ago (2014-04-16 18:04:19 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 22:14:50 UTC) #9
Message was sent while issue was closed.
Change committed as 264323

Powered by Google App Engine
This is Rietveld 408576698