Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 235893016: Some cleanups for the message_loop.h/cc. (Closed)

Created:
6 years, 8 months ago by sadrul
Modified:
6 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Some cleanups for the message_loop.h/cc. The cleanups include: * Remove some #includes and typedefs from message_loop.h * Remove MessageLoop::Observer, and add MessageLoopForUI:Observer instead. * Wrap all of MessageLoopForUI inside !defined(OS_NACL). * Remove some pump_*() accessors (e.g. pump_win(), pump_libevent()), and use static_cast<> instead where necessary. * Add a MessagePumpForIO typedef in message_loop.cc for the various IO message-pumps, and remove MESSAGE_PUMP_IO macro for creating the io pumps. * Simplify the #ifdef's for MESSAGE_PUMP_UI macro. BUG=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265451

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -146 lines) Patch
M base/message_loop/message_loop.h View 1 2 3 4 5 6 7 8 10 chunks +31 lines, -93 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 2 3 4 5 6 7 8 7 chunks +54 lines, -51 lines 0 comments Download
M base/message_loop/message_pump_glib.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
Do these look like reasonable cleanups? There are still quite a bit of #ifdef's after ...
6 years, 8 months ago (2014-04-22 20:26:30 UTC) #1
darin (slow to review)
LGTM
6 years, 8 months ago (2014-04-22 22:49:48 UTC) #2
sadrul
6 years, 8 months ago (2014-04-23 00:55:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #9 manually as r265451 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698